Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subdirs in tests/io/data #29513

Merged
merged 8 commits into from
Nov 13, 2019
Merged

Make subdirs in tests/io/data #29513

merged 8 commits into from
Nov 13, 2019

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 commented Nov 9, 2019

A few of the "network" tests are failing locally as they require the data on master:
e.g

  @tm.network
    def test_spam_url(self):
        url = (
            "https://raw.githubusercontent.com/pandas-dev/pandas/master/"
            "pandas/tests/io/data/html/spam.html"
        )
        df1 = self.read_html(url, ".*Water.*")
        df2 = self.read_html(url, "Unit")

        assert_framelist_equal(df1, df2)

^ Will change to this branch to get the test passing on this PR. Then in a follow up PR will revert to master unless any core devs have a different idea

@pep8speaks
Copy link

pep8speaks commented Nov 9, 2019

Hello @alimcmaster1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-13 14:52:13 UTC

@alimcmaster1 alimcmaster1 marked this pull request as ready for review November 9, 2019 16:58
@alimcmaster1 alimcmaster1 reopened this Nov 9, 2019
@WillAyd WillAyd added Clean Testing pandas testing functions or related to the test suite labels Nov 9, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 9, 2019

Yea the network stuff is a little wonky to manage when doing this, but note there is also non-network stuff mixed in. Out of the azure stuff I think only py36_locale_slow_old_np actually runs the network tests, so rest should be green

@alimcmaster1
Copy link
Member Author

Test failures now just 1 test related to - #29514

@jreback jreback added this to the 1.0 milestone Nov 12, 2019
@jreback
Copy link
Contributor

jreback commented Nov 12, 2019

i think if you merge master this will be green.

@alimcmaster1 alimcmaster1 reopened this Nov 13, 2019
@jreback jreback merged commit 33181d9 into pandas-dev:master Nov 13, 2019
@jreback
Copy link
Contributor

jreback commented Nov 13, 2019

thanks !

@alimcmaster1
Copy link
Member Author

No worries - I’ll attempt to fix that flakey test mentioned above

@alimcmaster1 alimcmaster1 deleted the mcmali-tests-dir-struct branch December 25, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants