-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make subdirs in tests/io/data #29513
Make subdirs in tests/io/data #29513
Conversation
Hello @alimcmaster1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-13 14:52:13 UTC |
Yea the network stuff is a little wonky to manage when doing this, but note there is also non-network stuff mixed in. Out of the azure stuff I think only |
Test failures now just 1 test related to - #29514 |
i think if you merge master this will be green. |
thanks ! |
No worries - I’ll attempt to fix that flakey test mentioned above |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
A few of the "network" tests are failing locally as they require the data on master:
e.g
^ Will change to this branch to get the test passing on this PR. Then in a follow up PR will revert to master unless any core devs have a different idea