TST: Add docstrings to arithmetic fixtures #29441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the contribution @dalgarno.
This looks like an improvement, but after reading the docstrings it's still not clear what those fixture do, or how they should be used. Do you mind trying to rephrase, and may be use examples?
datapythonista
changed the title
WillAyd
requested changes
Nov 8, 2019
| Several types of scalar zeros and length 5 vectors of zeros. For | ||
| testing division by (or of) zero. | ||
|
|
||
| Uses vector of length 5 for broadcasting with `numeric_idx` fixture, |
There was a problem hiding this comment.
Can you model the extended description here after what you have in the other method? I find that quite nice, but don't really understand this one
|
lgtm. side issue we should rename these to maybe |
|
@WillAyd can you approve if you're happy? |
datapythonista
approved these changes
Nov 17, 2019
WillAyd
approved these changes
Nov 18, 2019
|
Thanks @dalgarno |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #19159
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff