TST: new test for subset of a MultiIndex dtype #29356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
the
Testing
jreback
requested changes
Nov 2, 2019
pandas/tests/test_multilevel.py
Outdated
| False, | ||
| 0, | ||
| 0, | ||
| False, |
There was a problem hiding this comment.
can you make this a bit more programatic, rather than hardcoding these values, it would be easier to copy-paste
There was a problem hiding this comment.
Thanks for the feedback, @jreback! Reproduced the same behaviour with simpler input data.
pandas/tests/test_multilevel.py
Outdated
| columns = pd.MultiIndex.from_tuples(columns) | ||
| df = pd.DataFrame(data, columns=columns) | ||
|
|
||
| tm.assert_equal(df.dtypes.a.d.i, df.a.d.i.dtypes) |
There was a problem hiding this comment.
can you use
result=
expected=
tm.assert_frame_equal(result, equal)
There was a problem hiding this comment.
Thanks for the feedback, @jreback! Currently using tm.assert_series_equal(result, expected).
ganevgv
force-pushed
the
tests/subsets_multiindex_dtype
branch
from
dff9cab to
d71f8ac
Compare
ganevgv
force-pushed
the
tests/subsets_multiindex_dtype
branch
from
66742a6 to
7ea396e
Compare
jreback
approved these changes
Nov 16, 2019
|
thanks @ganevgv |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried unsuccessfully reproducing Issue #20757 on pandas: 0.23.0 and 0.26.0.dev0+734.g0de99558b.dirty. That's why I decided to keep the input data from Issue #20757 unchanged.
MultiIndexDataFramesometimes changesdtypes#20757black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff