CLN: catch less in pd.io #28862
CLN: catch less in pd.io #28862
Conversation
|
This is an intentional catch all that ensures the file gets cleanly closed. It could legitimately encounter a wide range of errors include memory exceptions, io exceptions, windows exceptions and probably others. The only reason why Exception is caught is so it can re reraised. The |
| else: | ||
| return tools.to_datetime(parsed, errors="ignore") | ||
|
|
||
| else: |
There was a problem hiding this comment.
this looks like a new path, is it actually hit?
this code seems to have gotten more complex as well.
There was a problem hiding this comment.
The to_datetime call below corresponds to the to_datetime call on 3274 in master. This is just moving it outside of the try/except.
| return generic_parser(date_parser, *date_cols) | ||
| else: |
There was a problem hiding this comment.
do we need this or the bottom else at all?
IOW if you just remove these and have the last line of the function do what you do on 3293 right now it seems cleaner?
There was a problem hiding this comment.
this isnt obvious, largely because we are dealing with a user-provided date_parser function. ill take another look
|
Closing to clear the queue |
@bashtage (only tangentially related to this PR) there is an
except Exceptionin pandas.io.stata that I'd like to make more specific. Any suggestions?