-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Deprecate Index.set_value #28621
DEPR: Deprecate Index.set_value #28621
Conversation
e775378
to
15fdd8c
Compare
15fdd8c
to
89b0bc2
Compare
Yeah that's right, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense so OK by me
doc/source/whatsnew/v1.0.0.rst
Outdated
- | ||
- :meth:`Index.set_values` has been deprecated. For a given index ``idx``, array ``arr``, | ||
value in ``idx`` of ``idx_val`` and a new value of ``val``, ``idx.set_value(arr, idx_val, val)`` | ||
is equivalent to ``arr[idx.get_loc(idx_val) = val``, which should be used instead (:issue:`28621`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is equivalent to ``arr[idx.get_loc(idx_val) = val``, which should be used instead (:issue:`28621`). | |
is equivalent to ``arr[idx.get_loc(idx_val) = val]``, which should be used instead (:issue:`28621`). |
missing end bracket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ping on green
doc/source/whatsnew/v1.0.0.rst
Outdated
@@ -116,7 +116,9 @@ Other API changes | |||
Deprecations | |||
~~~~~~~~~~~~ | |||
|
|||
- | |||
- :meth:`Index.set_values` has been deprecated. For a given index ``idx``, array ``arr``, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this actually render? you should remove set_values from api.rst
3a2befb
to
b708d92
Compare
I've updated the PR according to comments. In addition, I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @jreback
Thanks! |
* master: (22 commits) DOC: fix PR09,PR08 errors for pandas.Timestamp (pandas-dev#28739) WEB: Add diversity note to team.md (pandas-dev#28630) DOC: Minor fixes in pandas/testing.py docstring. (pandas-dev#28752) TST: port maybe_promote tests from pandas-dev#23982 (pandas-dev#28764) Bugfix/groupby datetime issue (pandas-dev#28569) reenable codecov (pandas-dev#28750) CLN: Centralised _check_percentile (pandas-dev#27584) DEPR: Deprecate Index.set_value (pandas-dev#28621) CLN: Fix typo in contributing.rst (pandas-dev#28761) Fixed docstring errors in pandas.period range and pandas.PeriodIndex (pandas-dev#28756) BUG: Fix TypeError raised in libreduction (pandas-dev#28643) DOC: Pandas.Series.drop docstring PR02 (pandas-dev#27976) (pandas-dev#28742) DOC: Fixed doctring errors PR08, PR09 in pandas.io (pandas-dev#28748) TST: Fix broken test cases where Timedelta/Timestamp raise (pandas-dev#28729) REF: Consolidate alignment calls in DataFrame ops (pandas-dev#28638) BUG: Fix dep generation (pandas-dev#28734) Added doctstring to fixture (pandas-dev#28727) DOC: Fixed PR06 docstrings errors in pandas.timedelta_range (pandas-dev#28719) replaced safe_import with a corresponding test decorator (pandas-dev#28731) BUG: Fix RangeIndex.get_indexer for decreasing RangeIndex (pandas-dev#28680) ...
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Deprecates
Index.set_value
. This is a very little used and confusing method IMO.For a given index
idx
, arrayarr
, valueidx_val
inidx
and a new value ofval
,idx.set_value(arr, idx_val, val)
is equivalent toarr[idx.get_loc(idx_val) = val
, which is more standard and should be used instead.