Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fixed PR08 docstring errors in pandas.tseries #28571

Merged
merged 11 commits into from
Oct 1, 2019
Merged

DOC: Fixed PR08 docstring errors in pandas.tseries #28571

merged 11 commits into from
Oct 1, 2019

Conversation

jb8429
Copy link
Contributor

@jb8429 jb8429 commented Sep 22, 2019 •
edited
Loading

This relates to: 27977. I have fixed the doc PR08 formatting issues for:

pandas.tseries.offsets.CustomBusinessDay: Parameter "weekmask" description should start with a capital letter
pandas.tseries.offsets.CustomBusinessDay: Parameter "holidays" description should start with a capital letter
pandas.tseries.offsets.WeekOfMonth: Parameter "week" description should start with a capital letter
pandas.tseries.offsets.WeekOfMonth: Parameter "weekday" description should start with a capital letter
pandas.tseries.offsets.LastWeekOfMonth: Parameter "weekday" description should start with a capital letter
pandas.tseries.offsets.FY5253: Parameter "weekday" description should start with a capital letter
pandas.tseries.offsets.FY5253: Parameter "variation" description should start with a capital letter
pandas.tseries.offsets.FY5253Quarter: Parameter "weekday" description should start with a capital letter
pandas.tseries.offsets.FY5253Quarter: Parameter "qtr_with_extra_week" description should start with a capital letter
pandas.tseries.offsets.FY5253Quarter: Parameter "variation" description should start with a capital letter
pandas.tseries.offsets.CDay: Parameter "weekmask" description should start with a capital letter
pandas.tseries.offsets.CDay: Parameter "holidays" description should start with a capital letter
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Will continue to work through all PR08 docstring errors.

@jb8429 jb8429 closed this Sep 23, 2019
@jb8429 jb8429 deleted the docs-pr08 branch September 23, 2019 21:10
@jb8429 jb8429 restored the docs-pr08 branch September 23, 2019 21:12
@jb8429 jb8429 reopened this Sep 23, 2019
@pep8speaks
Copy link

pep8speaks commented Sep 26, 2019 •
edited
Loading

Hello @jackbicknell14! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-27 08:45:33 UTC

@jb8429 jb8429 mentioned this pull request Sep 27, 2019
Closed
2 tasks
@jb8429 jb8429 changed the title Updated tseries.offsets for docstring errors PR08 DOC: Fixed PR08 docstring errors in pandas.tseries Sep 27, 2019
@jb8429 jb8429 mentioned this pull request Sep 30, 2019
Merged
3 tasks
@WillAyd WillAyd added the Docs label Oct 1, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 1, 2019
@WillAyd WillAyd merged commit b1c3a90 into pandas-dev:master Oct 1, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 1, 2019

Thanks @jackbicknell14 !

josibake pushed a commit to josibake/pandas that referenced this pull request Oct 1, 2019
@jb8429
DOC: Fixed PR08 docstring errors in pandas.tseries (pandas-dev#28571)
225d5e2
@jb8429 jb8429 deleted the docs-pr08 branch October 1, 2019 18:51
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jb8429 @proost
DOC: Fixed PR08 docstring errors in pandas.tseries (pandas-dev#28571)
7225b0f
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jb8429 @proost
DOC: Fixed PR08 docstring errors in pandas.tseries (pandas-dev#28571)
73d3245
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@jb8429
DOC: Fixed PR08 docstring errors in pandas.tseries (pandas-dev#28571)
c521de2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jb8429 @pep8speaks @WillAyd