BUG: Fix merging non-indexes causes Index dtype promotion in when keys are missing #28436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a MultiIndex is getting mixed up with a RangeIndex. Did this pass locally? |
|
I ran the merging unit tests in test_merge. I'll spend some time to fix the others |
dworvos
force-pushed
the
fix_merge_non_index
branch
from
59b8977 to
a0a95c2
Compare
dworvos
force-pushed
the
fix_merge_non_index
branch
3 times, most recently
from
2de0f23 to
23b37c3
Compare
|
can you merge master and will have a look |
dworvos
force-pushed
the
fix_merge_non_index
branch
2 times, most recently
from
3e1b7f0 to
730c97c
Compare
|
I've rebased with upstream/master. Thanks! |
|
Just checking in to see if I did what you asked of correctly. Cheers |
|
@dworvos needs another rebase |
…s are missing from left or right side. (GH28220) Also closes GH24897, GH24212, and GH17257
dworvos
force-pushed
the
fix_merge_non_index
branch
from
730c97c to
ec70eee
Compare
|
@dworvos i think we'd take this, but needs some work if you want to continue, pls ping |
|
Sure, I can take a look, but I'd like some feedback on what needs to be done rather than just constantly rebasing and getting nowhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... from left or right side. (GH28220)
Also closes GH24897, GH24212, and GH17257
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffProbably requires a bit more cleanup and reduction of spaghetti... Not in love with the the solution (as it's quite similar to using both indexes) and requires extension test case changes, but hoping to get some comments and feedback on making it better.