Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: boxplot does not work when data has datetime column #27846

Merged
merged 16 commits into from
Aug 13, 2019

Conversation

charlesdong1991
Copy link
Member

@gfyoung gfyoung added Regression Functionality that used to work in a prior pandas version Visualization plotting labels Aug 9, 2019
@gfyoung gfyoung requested a review from TomAugspurger August 9, 2019 20:26
# GH22799, exclude datatime type for boxplot
include_type = [np.number, "datetime", "datetimetz", "timedelta"]
if self._kind == "box":
include_type.remove("datetime")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does datetimetz work? Or does it need to be excluded here too?

Copy link
Member Author

@charlesdong1991 charlesdong1991 Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, yeah, should exclude datetime-like... thanks for pointing out! @TomAugspurger

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the release not. LGTM otherwise.

doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved
@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 12, 2019
@TomAugspurger TomAugspurger merged commit b623a9d into pandas-dev:master Aug 13, 2019
@TomAugspurger
Copy link
Contributor

Thanks @charlesdong1991!

quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Functionality that used to work in a prior pandas version Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: boxplot does not work when there is a datetime64 column
3 participants