Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: GroupBy.head()/tail() documentation #27844

Merged

Conversation

mtrbean
Copy link
Contributor

@mtrbean mtrbean commented Aug 9, 2019

Update DOC to make it consistent with actual behavior

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, couple of minor comments. @jorisvandenbossche you proposed the change in the issue, do you want to have a look?

pandas/core/groupby/groupby.py Outdated Show resolved Hide resolved
pandas/core/groupby/groupby.py Outdated Show resolved Hide resolved
@mtrbean mtrbean force-pushed the GH-6721-groupby-head-doc branch from bd6b10d to 27034cb Compare August 9, 2019 21:31
@mtrbean
Copy link
Contributor Author

mtrbean commented Aug 9, 2019

added double backticks to as_index as suggested

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up!

pandas/core/groupby/groupby.py Outdated Show resolved Hide resolved
pandas/core/groupby/groupby.py Outdated Show resolved Hide resolved
@mtrbean mtrbean force-pushed the GH-6721-groupby-head-doc branch from 27034cb to 76439de Compare August 20, 2019 17:27
@pep8speaks
Copy link

pep8speaks commented Aug 20, 2019

Hello @mtrbean! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-08-20 17:29:07 UTC

@mtrbean mtrbean force-pushed the GH-6721-groupby-head-doc branch from 76439de to a8ed787 Compare August 20, 2019 17:29
@mtrbean
Copy link
Contributor Author

mtrbean commented Aug 20, 2019

@jorisvandenbossche I've updated the PR per your comment

@mtrbean
Copy link
Contributor Author

mtrbean commented Aug 22, 2019

@jorisvandenbossche @datapythonista ping again

@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Aug 23, 2019
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks a lot!

@jorisvandenbossche jorisvandenbossche merged commit 888d1fa into pandas-dev:master Aug 23, 2019
galuhsahid pushed a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
galuhsahid added a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
* master: (40 commits)
  DOC: Fix GL01 and GL02 errors in the docstrings (pandas-dev#27988)
  Remove Encoding of values in char** For Labels (pandas-dev#27618)
  TYPING: more type hints for io.formats.printing (pandas-dev#27765)
  TST: fix compression tests when run without virtualenv/condaenv (pandas-dev#28051)
  DOC: Start 0.25.2 (pandas-dev#28111)
  DOC: Fix docstrings lack of punctuation (pandas-dev#28031)
  DOC: Remove alias for numpy.random.randn from the docs (pandas-dev#28082)
  DOC: update GroupBy.head()/tail() documentation (pandas-dev#27844)
  BUG: timedelta merge asof with tolerance (pandas-dev#27650)
  BUG: Series.rename raises error on values accepted by Series construc… (pandas-dev#27814)
  Preserve index when setting new column on empty dataframe. (pandas-dev#26471)
  BUG: Fixed groupby quantile for listlike q (pandas-dev#27827)
  BUG: iter with readonly values, closes pandas-dev#28055 (pandas-dev#28074)
  TST: non-strict xfail for period test (pandas-dev#28072)
  DOC: Update whatsnew (pandas-dev#28073)
  CI: disable codecov (pandas-dev#28065)
  CI: Set SHA for codecov upload (pandas-dev#28067)
  BUG: Correct the previous bug fixing on xlim for plotting (pandas-dev#28059)
  CI: Add pip dependence explicitly (pandas-dev#28008)
  DOC: Change document code prun in a row (pandas-dev#28029)
  ...
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in DataFrameGroupBy.head()
5 participants