improve warnings for Series.{real,imag} #27651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Jul 29, 2019
gfyoung
added
Error Reporting
gfyoung
reviewed
Jul 30, 2019
pandas/core/series.py
Outdated
| "`real` has be deprecated and will be removed in a future version", | ||
| "`real` has be deprecated and will be removed in a future " | ||
| "version. To eliminate this warning for a Series `ser`, use " | ||
| "`np.real(ser.to_array())` or `ser.to_array().real`.", |
There was a problem hiding this comment.
Should the to_array be a to_numpy ?
pandas/core/series.py
Outdated
| @@ -955,7 +955,9 @@ def real(self): | |||
| .. deprecated:: 0.25.0 | |||
| """ | |||
| warnings.warn( | |||
| "`real` has be deprecated and will be removed in a future version", | |||
| "`real` has be deprecated and will be removed in a future " | |||
There was a problem hiding this comment.
Suggested change
| "`real` has be deprecated and will be removed in a future " | |
| "`real` is deprecated and will be removed in a future " |
fixing an existing typo at once
pandas/core/series.py
Outdated
| @@ -973,7 +975,9 @@ def imag(self): | |||
| .. deprecated:: 0.25.0 | |||
| """ | |||
| warnings.warn( | |||
| "`imag` has be deprecated and will be removed in a future version", | |||
| "`imag` has be deprecated and will be removed in a future " | |||
There was a problem hiding this comment.
Suggested change
| "`imag` has be deprecated and will be removed in a future " | |
| "`imag` is deprecated and will be removed in a future " |
jorisvandenbossche
approved these changes
Jul 30, 2019
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jul 30, 2019
TomAugspurger
pushed a commit
that referenced
this pull request
Jul 30, 2019
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff