Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: refactor roll_generic to call roll_generic_with_indexer #27523

Closed
wants to merge 4 commits into from
Closed

CLN: refactor roll_generic to call roll_generic_with_indexer #27523

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2019

Make it possible for users to directly supply their own indexer when pandas doesn't provide what they want out of the box. This is useful for quickly doing something like "groupby" with overlapping groups (xref #26959) and/or strided rolling.

pilkibun added 4 commits July 22, 2019 10:34
…neric

* origin/master:
  xfail to fix CI (#27536)
  REF: de-privatize dtypes.concat functions (#27499)
  stop conflating iNaT with td64-NaT (#27411)
  BUG: Fix inserting of wrong-dtyped NaT, closes #27297 (#27311)
  BUG: Retain tz transformation in groupby.transform (#27510)
  remove references to v0.19 in docs and code (#27508)
  remove last references to v0.18 in docs and code (#27507)
  CLN: avoid runtime imports (#27461)
@simonjayhawkins
Copy link
Member

Make it possible for users to directly supply their own indexer when pandas doesn't provide what they want out of the box.

does this need some documentation?

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is too specific, meaning would take a change like this but it should be generic to all aggregation functions. This maybe a large effort.

@jreback jreback added the Window rolling, ewma, expanding label Jul 26, 2019
@ghost ghost closed this Jul 26, 2019
@ghost ghost deleted the refactor_rolling_generic branch July 26, 2019 14:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants