PERF: restore performance for unsorted CategoricalDtype comparison #27448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a performance regression introduced in #26403 very shortly before
0.25.0rc0
was cut, which can be seen hereWhen comparing
CategoricalDtype
s withordered=False
(the default), a hash is currently done that is relatively slow even for a small number of categories. If we check if the categories happen to be the same and in the same order, we see a significant speedup in the equal case. The.equals()
function pre-exits, so overhead in the non-equal case should be minimal.asv
results:black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff