TST/CLN: engine fixture for tests/io/excel/test_readers.py #27139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Testing
WillAyd
approved these changes
Jun 30, 2019
| @@ -224,7 +224,7 @@ def test_read_excel_parse_dates(self, ext): | |||
| class _WriterBase: | |||
There was a problem hiding this comment.
Doesn't need to be done here but we can probably get rid of this class altogether since it only contains the fixture. I also think it is better to use partials instead of setting global settings (we do this on the reading side) so something to look at in the future if you are interested in closing #27096
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixture for todos from #27114
use of safe_import in pytest.param #26735 (comment) #26784
cc @WillAyd