Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: Adding missing doc dependencies to environment.yml #26657

Merged
merged 1 commit into from
Jun 5, 2019
Merged

DEPS: Adding missing doc dependencies to environment.yml #26657

merged 1 commit into from
Jun 5, 2019

Conversation

datapythonista
Copy link
Member

In #26648 we detected that environment.yml didn't contain some of the dependencies required to build the documentation. environment.yml is what we use to build the documentation locally. Adding them here.

CC: @jorisvandenbossche

@datapythonista datapythonista added Docs Dependencies Required and optional dependencies labels Jun 5, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #26657 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26657      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50683    50683              
==========================================
- Hits        46567    46564       -3     
- Misses       4116     4119       +3
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.81% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.91% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d97d4...4d0d731. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #26657 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26657      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50683    50683              
==========================================
- Hits        46567    46564       -3     
- Misses       4116     4119       +3
Flag Coverage Δ
#multiple 90.41% <ø> (ø) ⬆️
#single 41.81% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.91% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d97d4...4d0d731. Read the comment docs.

- isort
- moto
- mypy
- nbconvert>=5.4.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put some comments and/or group dependencies in this file as much as possible

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, didn't think about additional grouping which makes sense, but was thinking on a comment for each dependency to explain where/why is needed. Otherwise will be difficult to know when any can be removed.

May be in a separate PR, since all them need it, and it's unrelated to the changes here? I'll create an issue, we have a sprint tonight where surely someone can work on it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure that's fine; I think grouping with a single comment is prob good enough

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #26659

@jreback jreback added this to the 0.25.0 milestone Jun 5, 2019
@jreback jreback merged commit 758e35d into pandas-dev:master Jun 5, 2019
@WillAyd
Copy link
Member

WillAyd commented Jun 5, 2019

Hmm this might cause some issues with xlrd throwing pending deprecation warnings as defusedxml seems to be getting installed as a dependency.

Seeing that locally at least let's see if it comes up in CI

@datapythonista
Copy link
Member Author

The CI is not using this file. May be you can open a issue with what you see> I didn't see any new warning in the documentation build, didn't run the tests with this environment after the change.

@WillAyd
Copy link
Member

WillAyd commented Jun 5, 2019

For sure. I think it might be manifested in #22682 though if I see something more concrete will open an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants