Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove usage of lrange in docs #26423

Merged
merged 1 commit into from
May 16, 2019

Conversation

jorisvandenbossche
Copy link
Member

Due to the recent removals (eg #26396 and others)

@jorisvandenbossche jorisvandenbossche added this to the 0.25.0 milestone May 16, 2019
@jorisvandenbossche
Copy link
Member Author

Verified the log that this is fixed

@jorisvandenbossche jorisvandenbossche merged commit cb6e47d into pandas-dev:master May 16, 2019
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26423 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26423      +/-   ##
==========================================
- Coverage   91.69%   91.69%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46529    46525       -4     
- Misses       4212     4216       +4
Flag Coverage Δ
#multiple 90.19% <ø> (ø) ⬆️
#single 41.16% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421ae9d...1f061de. Read the comment docs.

@topper-123
Copy link
Contributor

pd.DataFrame(range(10)) doesn't work in 0.24 (fixed for 0.25), so will likely not have worked in the older versions either. Maybe too late, but I think pd.DataFrame(list(range(10))) could be better, as these are release notes?

@jorisvandenbossche
Copy link
Member Author

Ah, good point. I actually made sure I tested it, as I was not sure if I needed to use list(..) or not, but I was using master .. ;)

@jorisvandenbossche jorisvandenbossche deleted the doc-fixes branch May 16, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants