Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: remove __unicode__ from pandas.core.dtypes #26415

Merged
merged 1 commit into from
May 15, 2019

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented May 15, 2019

Removes use of __unicode__ from the pandas.core.dtypes namespace.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #26415 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26415      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50739    50737       -2     
==========================================
- Hits        46524    46518       -6     
- Misses       4215     4219       +4
Flag Coverage Δ
#multiple 90.19% <85.71%> (-0.01%) ⬇️
#single 41.18% <85.71%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/core/dtypes/dtypes.py 96.65% <85.71%> (-0.02%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4437e...c10ff78. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #26415 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26415      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50739    50737       -2     
==========================================
- Hits        46524    46518       -6     
- Misses       4215     4219       +4
Flag Coverage Δ
#multiple 90.19% <85.71%> (-0.01%) ⬇️
#single 41.18% <85.71%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/core/dtypes/dtypes.py 96.65% <85.71%> (-0.02%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4437e...c10ff78. Read the comment docs.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@WillAyd WillAyd added this to the 0.25.0 milestone May 15, 2019
@jreback jreback merged commit 241af3d into pandas-dev:master May 15, 2019
@jreback
Copy link
Contributor

jreback commented May 15, 2019

thanks @topper-123 imagine we have a these

@topper-123 topper-123 deleted the unicode_in_pandas.core.dtypes branch May 16, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants