Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Test doctests in pandas/core/tools/datetimes.py #26402

Merged
merged 2 commits into from
May 15, 2019

Conversation

HyukjinKwon
Copy link
Contributor

@HyukjinKwon HyukjinKwon commented May 15, 2019

@HyukjinKwon HyukjinKwon force-pushed the fix-doctest-datetimes branch from 8a515a7 to b032b53 Compare May 15, 2019 06:06
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #26402 into master will decrease coverage by 50.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26402       +/-   ##
===========================================
- Coverage   91.69%   41.17%   -50.52%     
===========================================
  Files         174      174               
  Lines       50743    50743               
===========================================
- Hits        46527    20894    -25633     
- Misses       4216    29849    +25633
Flag Coverage Δ
#multiple ?
#single 41.17% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 34.77% <ø> (-50.29%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b24fb6...b032b53. Read the comment docs.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #26402 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26402      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50743    50743              
==========================================
- Hits        46527    46524       -3     
- Misses       4216     4219       +3
Flag Coverage Δ
#multiple 90.19% <ø> (ø) ⬆️
#single 41.17% <ø> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/datetimes.py 85.05% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b24fb6...98c358a. Read the comment docs.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

pandas/core/tools/datetimes.py Outdated Show resolved Hide resolved
@jreback jreback added this to the 0.25.0 milestone May 15, 2019
@jreback jreback merged commit 5468cc0 into pandas-dev:master May 15, 2019
@jreback
Copy link
Contributor

jreback commented May 15, 2019

thanks @HyukjinKwon

@HyukjinKwon
Copy link
Contributor Author

Thank you @jorisvandenbossche and @jreback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test doctests in pandas/core/tools/datetimes.py
3 participants