Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Correct gcsfs install on Azure #26358

Merged
merged 1 commit into from
May 12, 2019
Merged

BLD: Correct gcsfs install on Azure #26358

merged 1 commit into from
May 12, 2019

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented May 12, 2019

Follow-up #26352

Also realized that the gcsfs install was placed in the wrong place (needs to be placed after the activate command). However, you will notice then that the install is the culprit for the earlier 3.7 build failures (something is not right on conda-forge and / with gcsfs and 3.7). Note though that the install of gcsfs works just fine on 3.6.

@gfyoung gfyoung added Build Library building on various platforms Windows Windows OS labels May 12, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone May 12, 2019
@jreback
Copy link
Contributor

jreback commented May 12, 2019

can u make an issue for follow up on this as well (or can just repurpose the closed one)

@gfyoung gfyoung added CI Continuous Integration and removed Build Library building on various platforms labels May 12, 2019
@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #26358 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26358      +/-   ##
==========================================
+ Coverage   92.04%   92.04%   +<.01%     
==========================================
  Files         175      175              
  Lines       52289    52289              
==========================================
+ Hits        48130    48131       +1     
+ Misses       4159     4158       -1
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 40.87% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4f5bd...dddcfd2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #26358 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26358      +/-   ##
==========================================
+ Coverage   92.04%   92.04%   +<.01%     
==========================================
  Files         175      175              
  Lines       52289    52289              
==========================================
+ Hits        48130    48131       +1     
+ Misses       4159     4158       -1
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 40.87% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 90.7% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4f5bd...dddcfd2. Read the comment docs.

@jreback jreback merged commit 6b51c94 into master May 12, 2019
@jreback
Copy link
Contributor

jreback commented May 12, 2019

thanks @gfyoung

@gfyoung gfyoung deleted the azure-win-37-followup branch May 12, 2019 22:12
@WillAyd
Copy link
Member

WillAyd commented May 15, 2019

Interestingly enough this is still throwing the Malformed error during CI:

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=11454&view=logs&jobId=76104ccd-8dcc-5006-a17c-28bcdd709542&taskId=abfb9918-2617-5bb0-6d25-709630145a2e&lineStart=941&lineEnd=942&colStart=1&colEnd=1

Though builds are coming out green. Maybe something with our gcsfs coverage we need to look into?

@gfyoung
Copy link
Member Author

gfyoung commented May 15, 2019

gcsfs is an optional dependency. Thus, we skip any tests (which there are some) that require this library if it isn’t installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Windows Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants