Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP} Fix type annotation in pandas/core/api #26341

Merged
merged 7 commits into from
May 12, 2019

Conversation

vaibhavhrt
Copy link
Contributor

@vaibhavhrt vaibhavhrt commented May 11, 2019

@vaibhavhrt
Copy link
Contributor Author

@WillAyd please take a look. Mypy is showing a lot of errors in setup.py and one in pandas\core\computation\expr.py when running locally, not sure why.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor issues as commented. Didn’t see the Mypy issue you mentioned above so maybe not an issue

pandas/core/arrays/integer.py Outdated Show resolved Hide resolved
pandas/core/arrays/integer.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #26341 into master will decrease coverage by 51.33%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26341       +/-   ##
===========================================
- Coverage   92.04%   40.71%   -51.34%     
===========================================
  Files         175      175               
  Lines       52292    52290        -2     
===========================================
- Hits        48133    21289    -26844     
- Misses       4159    31001    +26842
Flag Coverage Δ
#multiple ?
#single 40.71% <100%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/integer.py 44% <100%> (-52.36%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0376c...2c22772. Read the comment docs.

@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #26341 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26341      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52292    52290       -2     
==========================================
- Hits        48133    48126       -7     
- Misses       4159     4164       +5
Flag Coverage Δ
#multiple 90.59% <100%> (-0.01%) ⬇️
#single 40.71% <100%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/integer.py 96.33% <100%> (-0.03%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.6% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0376c...2c22772. Read the comment docs.

@vaibhavhrt
Copy link
Contributor Author

vaibhavhrt commented May 11, 2019

@WillAyd I have addressed all the issues and tests should pass now(except the one that's failing on build stage). But codecov says coverage decreasing by 51%, do I need to write some tests too?

@gfyoung gfyoung added the Typing type annotations, mypy/pyright type checking label May 11, 2019
@jreback jreback added this to the 0.25.0 milestone May 11, 2019
@jreback
Copy link
Contributor

jreback commented May 11, 2019

this is fine. waiting on the resolution of the CI, then will have you rebase.

@jreback jreback merged commit 4e4f5bd into pandas-dev:master May 12, 2019
@jreback
Copy link
Contributor

jreback commented May 12, 2019

thanks @vaibhavhrt

@vaibhavhrt vaibhavhrt deleted the type-annotation-pandas/core/api branch May 13, 2019 08:08
@vaibhavhrt
Copy link
Contributor Author

vaibhavhrt commented May 13, 2019

Part of #25882, One more item in todo list of that issue can be marked completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Type Annotation in pandas/core/api.py
4 participants