-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP} Fix type annotation in pandas/core/api #26341
[WIP} Fix type annotation in pandas/core/api #26341
Conversation
@WillAyd please take a look. Mypy is showing a lot of errors in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some minor issues as commented. Didn’t see the Mypy issue you mentioned above so maybe not an issue
Codecov Report
@@ Coverage Diff @@
## master #26341 +/- ##
===========================================
- Coverage 92.04% 40.71% -51.34%
===========================================
Files 175 175
Lines 52292 52290 -2
===========================================
- Hits 48133 21289 -26844
- Misses 4159 31001 +26842
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26341 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52292 52290 -2
==========================================
- Hits 48133 48126 -7
- Misses 4159 4164 +5
Continue to review full report at Codecov.
|
@WillAyd I have addressed all the issues and tests should pass now(except the one that's failing on build stage). But codecov says coverage decreasing by 51%, do I need to write some tests too? |
this is fine. waiting on the resolution of the CI, then will have you rebase. |
thanks @vaibhavhrt |
Part of #25882, One more item in todo list of that issue can be marked completed. |
git diff upstream/master -u -- "*.py" | flake8 --diff