-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: regression fixup for timestamp.TimestampConstruction.time_parse_iso8601_tz benchmark #26334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26334 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52297 52297
==========================================
- Hits 48137 48134 -3
- Misses 4160 4163 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26334 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 175 175
Lines 52292 52292
==========================================
- Hits 48132 48129 -3
- Misses 4160 4163 +3
Continue to review full report at Codecov.
|
@anmyachev : Nice! Can you show the result of the entire benchmark suite? |
@gfyoung
|
@anmyachev : I meant the entire benchmark suite, just in case. |
this looks fine; waiting on CI resolution. |
687590f
to
40ad4dd
Compare
@gfyoung entire benchmark suite will be later. |
thanks @anmyachev |
git diff upstream/master -u -- "*.py" | flake8 --diff
For detection details see: #26220 (comment)
The slowdown was due to the use of
convert_to_tsobject
function.Asv result: