CLN: remove unneeded inheritance from base object #26128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
remove_inheritance_from_object
branch
from
fb20412 to
0c56f26
Compare
Codecov Report
@@ Coverage Diff @@
## master #26128 +/- ##
==========================================
- Coverage 91.99% 91.98% -0.02%
==========================================
Files 175 175
Lines 52387 52384 -3
==========================================
- Hits 48192 48184 -8
- Misses 4195 4200 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26128 +/- ##
==========================================
- Coverage 91.99% 91.98% -0.01%
==========================================
Files 175 175
Lines 52385 52382 -3
==========================================
- Hits 48190 48184 -6
- Misses 4195 4198 +3
Continue to review full report at Codecov.
|
topper-123
force-pushed
the
remove_inheritance_from_object
branch
from
0c56f26 to
0ec6fc2
Compare
gfyoung
added
2/3 Compat
Clean
Testing
WillAyd
approved these changes
Apr 18, 2019
jreback
requested changes
Apr 18, 2019
| @@ -140,10 +140,6 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then | |||
| invgrep -R --include="*.py" --include="*.pyx" -E "(DEPRECATED|DEPRECATE|Deprecated)(:|,|\.)" pandas | |||
| RET=$(($RET + $?)) ; echo $MSG "DONE" | |||
|
|
|||
| MSG='Check for old-style classes' ; echo $MSG | |||
There was a problem hiding this comment.
why are you removing this?
There was a problem hiding this comment.
In python2 ´´class MyClass:´´ created an different class type (old style) than ´´class MyClass(object):`` (new style). Pandas required that all classes be new style for py2/py3 compatability. This distinction can be lifted now we only use python3, so the check isn`t needed any more.
There was a problem hiding this comment.
maybe so but we still don’t want them
i would revert the check
There was a problem hiding this comment.
I’ve added a check for the reverted case.
topper-123
force-pushed
the
remove_inheritance_from_object
branch
from
0ec6fc2 to
0c8bd24
Compare
|
topper-123
force-pushed
the
remove_inheritance_from_object
branch
from
0c8bd24 to
3dc58d6
Compare
jreback
approved these changes
Apr 18, 2019
|
thanks @topper-123 |
yhaque1213
pushed a commit
to yhaque1213/pandas
that referenced
this pull request
Apr 22, 2019
ryanreh99
added a commit
to ryanreh99/pandas
that referenced
this pull request
Apr 22, 2019
1 task
gfyoung
pushed a commit
that referenced
this pull request
Apr 27, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a tedious whopper to review (sorry), but this PR removes all instances of inheriting from the base
objectfrom the code base, as dropping Python2 support means that this particular idiom is no longer needed.Additionally, as part of the above, I've removed the check in code_checks.sh that classes must inherit, as that is no longer a requirement after dropping Python2. I don't think a different check is possible to do now, but I can change instead of delete the check if anyone thinks that would make sense.