Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pandas.io.formats.css from MyPy Blacklist #25900

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Mar 28, 2019

There was a seemingly unused class variable which was failing mypy due to a lack of annotation. On closer inspection however it doesn't appear that this was even used, so I figured deletion makes things simpler.

I suppose if this was subclassed it could have some effect but this isn't part of the exposed API

@jnothman if you have any thoughts or objections

@WillAyd WillAyd added Code Style Code style, linting, code_checks Clean Typing type annotations, mypy/pyright type checking labels Mar 28, 2019
@jnothman
Copy link
Contributor

I suppose it doesn't have much use here, for now at least... Don't mind.

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #25900 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25900      +/-   ##
==========================================
+ Coverage   91.53%   91.53%   +<.01%     
==========================================
  Files         175      175              
  Lines       52808    52807       -1     
==========================================
  Hits        48338    48338              
+ Misses       4470     4469       -1
Flag Coverage Δ
#multiple 90.09% <100%> (-0.01%) ⬇️
#single 41.82% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/excel.py 97.4% <100%> (ø) ⬆️
pandas/io/formats/css.py 100% <100%> (ø) ⬆️
pandas/util/testing.py 90.56% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882961d...80f0523. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #25900 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25900      +/-   ##
==========================================
+ Coverage   91.53%   91.53%   +<.01%     
==========================================
  Files         175      175              
  Lines       52808    52807       -1     
==========================================
  Hits        48338    48338              
+ Misses       4470     4469       -1
Flag Coverage Δ
#multiple 90.09% <100%> (-0.01%) ⬇️
#single 41.82% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/excel.py 97.4% <100%> (ø) ⬆️
pandas/io/formats/css.py 100% <100%> (ø) ⬆️
pandas/util/testing.py 90.56% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882961d...80f0523. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Mar 28, 2019
@jreback jreback merged commit 7721f70 into pandas-dev:master Mar 28, 2019
@jreback
Copy link
Contributor

jreback commented Mar 28, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the cleanup-styler-code branch March 29, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Code Style Code style, linting, code_checks Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants