Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: exclude asv env directory from isort and tailing whitespace checks #25827

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

qwhelan
Copy link
Contributor

@qwhelan qwhelan commented Mar 21, 2019

When running ci/code_checks.sh on a local repository that has also been used to run asv benchmarks, a couple of the checks recurse into the asv_bench/env directory created for running benchmark environments. This massively increases the runtime and leads to linting errors on non-pandas packages, which is not informative.

This change simply adds env to the isort exclude list and the tailing whitespace grep call, which resolves the issue.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #25827 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25827      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files         173      173              
  Lines       53002    53002              
==========================================
- Hits        48376    48375       -1     
- Misses       4626     4627       +1
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.77% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 89.3% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31b4f4...10954bd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #25827 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25827      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files         173      173              
  Lines       53002    53002              
==========================================
- Hits        48376    48375       -1     
- Misses       4626     4627       +1
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.77% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 89.3% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31b4f4...10954bd. Read the comment docs.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me - thanks!

@WillAyd WillAyd added the Code Style Code style, linting, code_checks label Mar 22, 2019
@jreback jreback added this to the 0.25.0 milestone Mar 22, 2019
@jreback jreback merged commit aab42a2 into pandas-dev:master Mar 22, 2019
@jreback
Copy link
Contributor

jreback commented Mar 22, 2019

thanks @qwhelan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants