CI: exclude asv env directory from isort and tailing whitespace checks #25827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
ci/code_checks.sh
on a local repository that has also been used to runasv
benchmarks, a couple of the checks recurse into theasv_bench/env
directory created for running benchmark environments. This massively increases the runtime and leads to linting errors on non-pandas packages, which is not informative.This change simply adds
env
to theisort
exclude list and the tailing whitespacegrep
call, which resolves the issue.git diff upstream/master -u -- "*.py" | flake8 --diff