-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF remove unused imports from tseries.frequencies; update imports elsewhere #24834
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24834 +/- ##
==========================================
+ Coverage 92.38% 92.39% +<.01%
==========================================
Files 166 166
Lines 52382 52370 -12
==========================================
- Hits 48394 48385 -9
+ Misses 3988 3985 -3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24834 +/- ##
==========================================
+ Coverage 92.38% 92.39% +<.01%
==========================================
Files 166 166
Lines 52382 52370 -12
==========================================
- Hits 48394 48385 -9
+ Misses 3988 3985 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment about importing resolution, but can do in a followup.
@@ -5,7 +5,8 @@ | |||
import numpy as np | |||
|
|||
from pandas._libs import index as libindex | |||
from pandas._libs.tslibs import NaT, iNaT, resolution | |||
from pandas._libs.tslibs import ( | |||
NaT, frequencies as libfrequencies, iNaT, resolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe want to call this libresolution?
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff