Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF remove unused imports from tseries.frequencies; update imports elsewhere #24834

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #24834 into master will increase coverage by <.01%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24834      +/-   ##
==========================================
+ Coverage   92.38%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52382    52370      -12     
==========================================
- Hits        48394    48385       -9     
+ Misses       3988     3985       -3
Flag Coverage Δ
#multiple 90.81% <88.57%> (ø) ⬆️
#single 42.89% <25.71%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.52% <100%> (ø) ⬆️
pandas/core/indexes/period.py 92.06% <100%> (ø) ⬆️
pandas/tseries/frequencies.py 97.7% <100%> (+0.62%) ⬆️
pandas/core/resample.py 97.23% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.76% <100%> (-0.06%) ⬇️
pandas/plotting/_timeseries.py 65.46% <60%> (+0.17%) ⬆️
pandas/util/testing.py 88.13% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a07d685...5a993da. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #24834 into master will increase coverage by <.01%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24834      +/-   ##
==========================================
+ Coverage   92.38%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52382    52370      -12     
==========================================
- Hits        48394    48385       -9     
+ Misses       3988     3985       -3
Flag Coverage Δ
#multiple 90.81% <88.57%> (ø) ⬆️
#single 42.89% <25.71%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.52% <100%> (ø) ⬆️
pandas/core/indexes/period.py 92.06% <100%> (ø) ⬆️
pandas/tseries/frequencies.py 97.7% <100%> (+0.62%) ⬆️
pandas/core/resample.py 97.23% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.76% <100%> (-0.06%) ⬇️
pandas/plotting/_timeseries.py 65.46% <60%> (+0.17%) ⬆️
pandas/util/testing.py 88.13% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a07d685...5a993da. Read the comment docs.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment about importing resolution, but can do in a followup.

@@ -5,7 +5,8 @@
import numpy as np

from pandas._libs import index as libindex
from pandas._libs.tslibs import NaT, iNaT, resolution
from pandas._libs.tslibs import (
NaT, frequencies as libfrequencies, iNaT, resolution)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe want to call this libresolution?

@jreback jreback added Frequency DateOffsets Clean labels Jan 19, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 19, 2019
@jreback jreback merged commit f4458c1 into pandas-dev:master Jan 19, 2019
@jreback
Copy link
Contributor

jreback commented Jan 19, 2019

thanks!

@jbrockmendel jbrockmendel deleted the f401 branch January 19, 2019 22:29
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants