Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: replace %s syntax with .format in pandas.io #24719

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

makeajourney
Copy link
Contributor

progress towards #16130

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #24719 into master will increase coverage by <.01%.
The diff coverage is 82.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24719      +/-   ##
==========================================
+ Coverage   92.38%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52321    52321              
==========================================
+ Hits        48337    48338       +1     
+ Misses       3984     3983       -1
Flag Coverage Δ
#multiple 90.8% <25.37%> (ø) ⬆️
#single 43.06% <80.59%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/packers.py 88.21% <0%> (ø) ⬆️
pandas/io/sas/sas7bdat.py 91.16% <33.33%> (ø) ⬆️
pandas/io/pytables.py 92.31% <85.71%> (ø) ⬆️
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46d2a5...f3232f1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #24719 into master will increase coverage by <.01%.
The diff coverage is 82.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24719      +/-   ##
==========================================
+ Coverage   92.38%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52321    52321              
==========================================
+ Hits        48337    48338       +1     
+ Misses       3984     3983       -1
Flag Coverage Δ
#multiple 90.8% <25.37%> (ø) ⬆️
#single 43.06% <80.59%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/packers.py 88.21% <0%> (ø) ⬆️
pandas/io/sas/sas7bdat.py 91.16% <33.33%> (ø) ⬆️
pandas/io/pytables.py 92.31% <85.71%> (ø) ⬆️
pandas/util/testing.py 88.09% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46d2a5...f3232f1. Read the comment docs.

@jreback jreback added the Code Style Code style, linting, code_checks label Jan 11, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 11, 2019
@jreback jreback merged commit 3fe28fc into pandas-dev:master Jan 11, 2019
@jreback
Copy link
Contributor

jreback commented Jan 11, 2019

thanks!

@makeajourney makeajourney deleted the issue-16130-io branch January 11, 2019 13:01
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants