Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: for C extension builds on mac, target macOS 10.9 where possible #24274

Merged
merged 6 commits into from
Dec 28, 2018
Merged

BLD: for C extension builds on mac, target macOS 10.9 where possible #24274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
256faf2
BLD: mac builds target 10.9 on newer systems GH23424
robbuckley Dec 10, 2018
d98693e
PEP8 fixes
robbuckley Dec 11, 2018
9c5dc9f
use platform instead of _osx_support module
robbuckley Dec 12, 2018
7e1f12b
switch to LooseVersion, implicit line breaks
robbuckley Dec 15, 2018
34fca3f
udpate whatsnew
robbuckley Dec 20, 2018
f8c89c2
Merge branch 'master' into osx_pre10_9_build
robbuckley Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.24.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,7 @@ Build Changes

- Building pandas for development now requires ``cython >= 0.28.2`` (:issue:`21688`)
- Testing pandas now requires ``hypothesis>=3.58``. You can find `the Hypothesis docs here <https://hypothesis.readthedocs.io/en/latest/index.html>`_, and a pandas-specific introduction :ref:`in the contributing guide <using-hypothesis>`. (:issue:`22280`)
- Building pandas on macOS now targets minimum macOS 10.9 if run on macOS 10.9 or above (:issue:`23424`)

Other
^^^^^
Expand Down
19 changes: 19 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
from os.path import join as pjoin

import pkg_resources
import platform
from distutils.sysconfig import get_config_var
import sys
import shutil
from distutils.version import LooseVersion
Expand All @@ -24,6 +26,10 @@ def is_platform_windows():
return sys.platform == 'win32' or sys.platform == 'cygwin'


def is_platform_mac():
return sys.platform == 'darwin'


min_numpy_ver = '1.12.0'
setuptools_kwargs = {
'install_requires': [
Expand Down Expand Up @@ -434,6 +440,19 @@ def get_tag(self):
extra_compile_args = ['-Wno-unused-function']


# For mac, ensure extensions are built for macos 10.9 when compiling on a
# 10.9 system or above, overriding distuitls behaviour which is to target
# the version that python was built for. This may be overridden by setting
# MACOSX_DEPLOYMENT_TARGET before calling setup.py
if is_platform_mac():
if 'MACOSX_DEPLOYMENT_TARGET' not in os.environ:
current_system = LooseVersion(platform.mac_ver()[0])
python_target = LooseVersion(
get_config_var('MACOSX_DEPLOYMENT_TARGET'))
if python_target < '10.9' and current_system >= '10.9':
os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.9'


# enable coverage by building cython files by setting the environment variable
# "PANDAS_CYTHON_COVERAGE" (with a Truthy value) or by running build_ext
# with `--with-cython-coverage`enabled
Expand Down