Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupby Whitelist Cleanup #23972

Merged
merged 6 commits into from
Dec 25, 2018
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Nov 28, 2018

All of these methods are defined on the base GroupBy class so these essentially are no-ops in current state.

@pep8speaks
Copy link

pep8speaks commented Nov 28, 2018

Hello @WillAyd! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on December 25, 2018 at 07:20 Hours UTC

@jreback
Copy link
Contributor

jreback commented Nov 28, 2018

can you rebase and ping on green. i think some actual fails.

@jbrockmendel
Copy link
Member

Very much +1 on the goal. xref #16959

@jreback
Copy link
Contributor

jreback commented Dec 14, 2018

can you merge master

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #23972 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23972      +/-   ##
==========================================
+ Coverage    92.3%   92.31%   +<.01%     
==========================================
  Files         163      161       -2     
  Lines       51950    51473     -477     
==========================================
- Hits        47953    47516     -437     
+ Misses       3997     3957      -40
Flag Coverage Δ
#multiple 90.7% <100%> (-0.01%) ⬇️
#single 42.43% <100%> (-0.57%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/base.py 89.79% <100%> (-2.05%) ⬇️
pandas/core/sparse/scipy_sparse.py 97.05% <0%> (-2.95%) ⬇️
pandas/util/testing.py 86.09% <0%> (-1.67%) ⬇️
pandas/io/html.py 91.2% <0%> (-1.47%) ⬇️
pandas/core/indexes/timedeltas.py 89.18% <0%> (-1.24%) ⬇️
pandas/io/formats/html.py 97.63% <0%> (-1.01%) ⬇️
pandas/core/dtypes/common.py 94.77% <0%> (-0.86%) ⬇️
pandas/core/indexes/category.py 97.87% <0%> (-0.79%) ⬇️
pandas/compat/numpy/function.py 87.13% <0%> (-0.78%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159772d...430d3c1. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #23972 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23972      +/-   ##
==========================================
+ Coverage    92.3%    92.3%   +<.01%     
==========================================
  Files         163      163              
  Lines       51950    51950              
==========================================
+ Hits        47953    47954       +1     
+ Misses       3997     3996       -1
Flag Coverage Δ
#multiple 90.71% <100%> (ø) ⬆️
#single 42.99% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby/base.py 91.83% <100%> (ø) ⬆️
pandas/util/testing.py 87.84% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159772d...3f4689f. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 25, 2018
@jreback jreback merged commit 2a09706 into pandas-dev:master Dec 25, 2018
@jreback
Copy link
Contributor

jreback commented Dec 25, 2018

thanks!

@WillAyd WillAyd deleted the groupby-whitelist-cleanup branch December 26, 2018 23:51
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants