-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groupby Whitelist Cleanup #23972
Groupby Whitelist Cleanup #23972
Conversation
Hello @WillAyd! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 25, 2018 at 07:20 Hours UTC |
can you rebase and ping on green. i think some actual fails. |
Very much +1 on the goal. xref #16959 |
can you merge master |
Codecov Report
@@ Coverage Diff @@
## master #23972 +/- ##
==========================================
+ Coverage 92.3% 92.31% +<.01%
==========================================
Files 163 161 -2
Lines 51950 51473 -477
==========================================
- Hits 47953 47516 -437
+ Misses 3997 3957 -40
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #23972 +/- ##
==========================================
+ Coverage 92.3% 92.3% +<.01%
==========================================
Files 163 163
Lines 51950 51950
==========================================
+ Hits 47953 47954 +1
+ Misses 3997 3996 -1
Continue to review full report at Codecov.
|
thanks! |
All of these methods are defined on the base GroupBy class so these essentially are no-ops in current state.