-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/TST: doctests leaving extraneous files #23858
Conversation
Hello @RomainSa! Thanks for updating the PR.
Comment last updated on November 22, 2018 at 13:03 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #23858 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 161 161
Lines 51500 51500
=======================================
Hits 47528 47528
Misses 3972 3972
Continue to review full report at Codecov.
|
Looks good. @RomainSa did you run the doctests (the command is in the issue description) and verified that no file is created after running them? |
Yes, I used the command in issue description:
along with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great, and nothing else should be created then, I guess.
Thanks for fixing it @RomainSa
You're welcome, thanks for your feedback @datapythonista ! |
thanks @RomainSa |
git diff upstream/master -u -- "*.py" | flake8 --diff