Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/TST: doctests leaving extraneous files #23858

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

RomainSa
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Nov 22, 2018

Hello @RomainSa! Thanks for updating the PR.

Comment last updated on November 22, 2018 at 13:03 Hours UTC

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #23858 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23858   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         161      161           
  Lines       51500    51500           
=======================================
  Hits        47528    47528           
  Misses       3972     3972
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.02% <ø> (ø) ⬆️
pandas/core/generic.py 96.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ae454...9d1b415. Read the comment docs.

@datapythonista
Copy link
Member

Looks good.

@RomainSa did you run the doctests (the command is in the issue description) and verified that no file is created after running them?

@datapythonista datapythonista added Testing pandas testing functions or related to the test suite Docs labels Nov 22, 2018
@RomainSa
Copy link
Contributor Author

Yes, I used the command in issue description:

LINT=1 ci/code_check.sh

along with the git status command to make sure that the files initially created by the doctests were not created anymore after using the +SKIP flag

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great, and nothing else should be created then, I guess.

Thanks for fixing it @RomainSa

@RomainSa
Copy link
Contributor Author

You're welcome, thanks for your feedback @datapythonista !

@jreback jreback added this to the 0.24.0 milestone Nov 23, 2018
@jreback jreback merged commit 1e30a67 into pandas-dev:master Nov 23, 2018
@jreback
Copy link
Contributor

jreback commented Nov 23, 2018

thanks @RomainSa

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC/TST: doctests leaving extraneous files
4 participants