-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: move .str-test to strings.py & parametrize it; precursor to #23582 #23777
Conversation
Hello @h-vetinari! Thanks for submitting the PR.
|
Failure is rank segfault... |
thanks @h-vetinari |
…fixed * upstream/master: DOC: more consistent flake8-commands in contributing.rst (pandas-dev#23724) DOC: Fixed the doctsring for _set_axis_name (GH 22895) (pandas-dev#22969) DOC: Improve GL03 message re: blank lines at end of docstrings. (pandas-dev#23649) TST: add tests for keeping dtype in Series.update (pandas-dev#23604) TST: For GH4861, Period and datetime in multiindex (pandas-dev#23776) TST: move .str-test to strings.py & parametrize it; precursor to pandas-dev#23582 (pandas-dev#23777) STY: isort tests/scalar, tests/tslibs, import libwindow instead of _window (pandas-dev#23787) BUG: fixed .str.contains(..., na=False) for categorical series (pandas-dev#22170) BUG: Maintain column order with groupby.nth (pandas-dev#22811) API/DEPR: replace kwarg "pat" with "sep" in str.[r]partition (pandas-dev#23767) CLN: Finish isort core (pandas-dev#23765) TST: Mark test_pct_max_many_rows with pytest.mark.single (pandas-dev#23799)
@jreback Thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff
In #23582, I'm testing all string methods on all inferred dtypes (which uncovered lots of bugs that will be fixed by #23167 and follow-ups).
@jreback required #23582 to be broken up further, so here I'm moving one existing test that effectively uses the same idea to the (IMO) correct module (it's about testing the
.str
-accessor after all), where theany_string_method
fixture can then be used for both the test I'm moving in this PR, and the tests I'm introducing in #23582.It makes sense to have this fixture that's directly related to
.str
in the appropriate module, and not pollute the generalpandas/conftest.py
with it, that's mainly why I'm moving the test.