BUG: concat warning bubbling up through str.cat #23725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an unexpected realisation from #23723 -- the change of
pd.concat
in #20613 to addsort
and raise a warning if it's not specified was not caught in the.str.cat
code, because it was being shadowed (apparently in all relevant tests) by anotherFutureWarning
that's being raised ifjoin
is not specified (from #20347).This PR only adds the kwarg to the
.str.cat
internals where necessary.Example from #23723: