DOC: avoid SparseArray.take error #23637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes pandas-dev#22215 SparseArray.take not accepting scalars is already in 0.24.0.txt
jreback
reviewed
Nov 12, 2018
| @@ -266,7 +266,7 @@ These changes conform sparse handling to return the correct types and work to ma | |||
|
|
|||
| ``SparseArray.take`` now returns a scalar for scalar input, ``SparseArray`` for others. Furthermore, it handles a negative indexer with the same rule as ``Index`` (:issue:`10560`, :issue:`12796`) | |||
|
|
|||
| .. ipython:: python | |||
| .. code-block:: python | |||
|
This is "fixing" the doc build warning by not executing it. We changed API
to not allow scalars in SparseArray.take
…On Mon, Nov 12, 2018 at 8:40 AM Jeff Reback ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/source/whatsnew/v0.18.1.txt
<#23637 (comment)>:
> @@ -266,7 +266,7 @@ These changes conform sparse handling to return the correct types and work to ma
``SparseArray.take`` now returns a scalar for scalar input, ``SparseArray`` for others. Furthermore, it handles a negative indexer with the same rule as ``Index`` (:issue:`10560`, :issue:`12796`)
-.. ipython:: python
+.. code-block:: python
is this supposed to work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23637 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIsGaiZOcxjXbZcXJmKUKWWs0lXSyks5uuYhNgaJpZM4YZpe1>
.
|
Codecov Report
@@ Coverage Diff @@
## master #23637 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51326 51326
=======================================
Hits 47347 47347
Misses 3979 3979
Continue to review full report at Codecov.
|
wait, so then that should just raise? |
|
It does raise on master. This is in the 0.18.1 release notes.
…On Mon, Nov 12, 2018 at 9:39 AM Jeff Reback ***@***.***> wrote:
We changed API to not allow scalars in SparseArray.take
wait, so then that should just raise?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23637 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIuccwZ4AgIKJyh4LezXL_Y_Thr1kks5uuZYpgaJpZM4YZpe1>
.
|
|
oh! ic. ok then. |
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Nov 12, 2018
…fixed * upstream/master: DOC: avoid SparseArray.take error (pandas-dev#23637) CLN: remove incorrect usages of com.AbstractMethodError (pandas-dev#23625) DOC: Adding validation of the section order in docstrings (pandas-dev#23607) BUG: Don't over-optimize memory with jagged CSV (pandas-dev#23527) DEPR: Deprecate usecols as int in read_excel (pandas-dev#23635) More helpful Stata string length error. (pandas-dev#23629) BUG: astype fill_value for SparseArray.astype (pandas-dev#23547) CLN: datetimelike arrays: isort, small reorg (pandas-dev#23587) CI: Check in the CI that assert_raises_regex is not being used (pandas-dev#23627) CLN:Remove unused **kwargs from user facing methods (pandas-dev#23249)
avolkov
pushed a commit
to avolkov/pandas
that referenced
this pull request
Nov 13, 2018
Closes pandas-dev#22215 SparseArray.take not accepting scalars is already in 0.24.0.txt
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
Closes pandas-dev#22215 SparseArray.take not accepting scalars is already in 0.24.0.txt
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Closes pandas-dev#22215 SparseArray.take not accepting scalars is already in 0.24.0.txt
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Closes pandas-dev#22215 SparseArray.take not accepting scalars is already in 0.24.0.txt
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Closes pandas-dev#22215 SparseArray.take not accepting scalars is already in 0.24.0.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22215
SparseArray.take not accepting scalars is already in 0.24.0.txt