Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Rename raise_on_error to errors for .dtype #23374

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 27, 2018

Title is self-explanatory.

xref #14967.

@gfyoung gfyoung added Dtype Conversions Unexpected or buggy dtype conversions Deprecate Functionality to remove in pandas Clean labels Oct 27, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 27, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #23374 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23374      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         169      169              
  Lines       51261    51260       -1     
==========================================
- Hits        47277    47276       -1     
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <100%> (-0.01%) ⬇️
#single 42.22% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 96.79% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f662c5f...6fb1cec. Read the comment docs.

@jreback jreback merged commit 020782a into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks!

@gfyoung gfyoung deleted the astype-raise-on-error-remove branch October 28, 2018 05:22
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants