-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: sets in str.cat #23187
BUG: sets in str.cat #23187
Conversation
Hello @h-vetinari! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23187 +/- ##
=========================================
Coverage ? 92.19%
=========================================
Files ? 169
Lines ? 50956
Branches ? 0
=========================================
Hits ? 46978
Misses ? 3978
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, ping on green.
doc/source/whatsnew/v0.24.0.txt
Outdated
@@ -879,7 +879,7 @@ Numeric | |||
Strings | |||
^^^^^^^ | |||
|
|||
- | |||
- Bug in :meth:`Series.str.cat` which falsely did not raise if `others` was a `set` (:issue:`23009`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an api breaking change, so move it there. make this declerative as well, e.g. Series.str.cat will now raise if others is a set
@@ -301,7 +301,15 @@ def test_str_cat_mixed_inputs(self, box): | |||
with tm.assert_raises_regex(TypeError, rgx): | |||
s.str.cat([u, [u, d]]) | |||
|
|||
# forbidden input type, e.g. int | |||
# forbidden input type: set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the issue number here
4a9a94b
to
f447f05
Compare
f447f05
to
deb912e
Compare
thanks! |
This reverts commit 779aeac.
git diff upstream/master -u -- "*.py" | flake8 --diff
This is split off from #23065.