-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Validate parameter types in docstrings (e.g. str instead of string) #23165
DOC: Validate parameter types in docstrings (e.g. str instead of string) #23165
Conversation
Hello @Moisan! Thanks for updating the PR.
Comment last updated on October 15, 2018 at 14:38 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #23165 +/- ##
==========================================
+ Coverage 92.14% 92.19% +0.04%
==========================================
Files 170 169 -1
Lines 51017 50959 -58
==========================================
- Hits 47011 46980 -31
+ Misses 4006 3979 -27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, it's very useful. I'd just add the mentioned test, as it's more common having multiple types than just one.
---------- | ||
kind : boolean | ||
Foo bar baz. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add one test or two for something like list of boolean
, integer, float or string
... I think it makes sense to make sure that we capture them, and that the error in this case makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Moisan ! |
git diff upstream/master -u -- "*.py" | flake8 --diff
Related to #20298. Fixes the bullet "Using string, boolean, integer in the param descriptions (should be str, bool, int)".