DOC: Change release and whatsnew #21599

TomAugspurger · 2018-06-22T20:12:12Z

Some cleanup & changes to facilitate release automation

We will include the correct (latest on master or maintenance branch)
whatsnew directly in the index.rst toctree
Contributors are included in the whatsnew for each version (automatically)
Removed release.rst
Added new releases.rst which has toctrees for each release

Incidental changes

Updated style.ipynb. Writing the jinja template was confusing sphinx. We
included it in the git source now.
Fixing some inconsitent header levels (will do more)
Refactored announce.py to support auto-generated contributors

TODO:

Finish up the rest of the whatsnews

Changes: * We will include the correct (latest on master or maintenance branch) whatsnew directly in the index.rst toctree * Contributors are included in the whatsnew for each version (automatically) * Removed release.rst * Added new releases.rst which has toctrees for each release Incidental changes * Updated style.ipynb. Writing the jinja template was confusing sphinx. We included it in the git source now. * Fixing some inconsitent header levels (will do more) * Refactored announce.py to support auto-generated contributors

TomAugspurger · 2018-06-22T20:12:58Z

doc/source/conf.py

-source_suffix = '.rst'
+source_suffix = [
+    '.rst',
+    '.txt',


required so that the whatsnew files can be included in the toctree.

Is there actually a reason they are not *.rst ?

TomAugspurger · 2018-06-22T20:13:36Z

doc/source/conf.py

@@ -298,8 +303,39 @@
    for page in moved_api_pages
 }

+
+common_imports = """\


Previously we had this at the top of whatsnew.rst. Now it has to be in every whatsnew/v0.x.x.txt, as they are no longer literally included below this. Usage is just {{ common_imports }}

TomAugspurger · 2018-06-22T20:15:02Z

doc/source/conf.py

+    'v0.23.2': announce.build_string('v0.23.1..HEAD'),
+    'v0.23.1': announce.build_string('v0.23.0..v0.23.1'),
+    'v0.23.0': announce.build_string('v0.22.0..v0.23.0'),
+}


This is run every time we build the docs. It'll probably be run even for single page / docstring ones. I was concerned it would take a while, but it's surprisingly fast.

Once I finish the rest of the whatsnew, I'll time it again and look into ways of speeding it up if is a problem.

TomAugspurger · 2018-06-22T20:15:51Z

doc/source/conf.py

+    """
+    # http://ericholscher.com/blog/2016/jul/25/integrating-jinja-rst-sphinx/
+    # Make sure we're outputting HTML
+    if app.builder.format != 'html':


Hmm I should look into what happens for PDF. We should be able to handle it just fine.

TomAugspurger · 2018-06-22T20:16:12Z

doc/source/index.rst.template

@@ -118,7 +118,7 @@ See the package overview for more detail about what's in the library.
    {{ single_doc }}
    {% endif -%}
    {% if not single_doc -%}
-    whatsnew
+    What's New <whatsnew/v0.24.0>


We'll update this as part of the post-release process.

codecov · 2018-06-23T01:07:22Z

Codecov Report

Merging #21599 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21599   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51340    51340           
=======================================
  Hits        47361    47361           
  Misses       3979     3979

Flag	Coverage Δ
#multiple	`90.64% <ø> (ø)`	⬆️
#single	`42.34% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb8403...bc5d49e. Read the comment docs.

datapythonista · 2018-06-23T09:41:49Z

Looks really good. There is just one thing that I'd consider changing. I don't think it's a good practice to import functions from scripts/. Whn in the future someone make changes to the scripts, I don't think we will feel that we need to keep compatibility on any function defined there, as they can be imported by other parts of the code like the doc.

What I'd do instead is creating somewhere a directory "dev utils", where we can not only have the code of build_string but also the generation of contributors (and anything that could potentially be reused by the docs, the release, and may be the web). And if possible, I'd also automatically generate there the list of releases (0.23.0, 0.23.1...) so releases.rst and anything that requires the list of releases can be generated with the info from there (releases.rst would be a template as index.rst in that case).

pep8speaks · 2018-06-25T11:17:32Z

Hello @TomAugspurger! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on June 26, 2018 at 12:00 Hours UTC

datapythonista · 2018-06-25T12:56:58Z

doc/source/conf.py

+tags = [x.name for x in repo.tags if xpr.match(str(x))]
+versions = sorted(zip(tags,
+                      [tuple(map(int, xpr.match(x).groups())) for x in tags]),
+                  key=lambda x: x[1])


In case you don't know it, distutils provides a class to parse, sort... versions. You'd need to get rid of the heading v in v0.23.1. But then you can do this stuff automatically. For example:

>>> import distutils.version >>> tags = ['0.22.0', '0.23.0', '0.23.1', '0.21.1', '0.21.0'] >>> versions = map(distutils.version.StrictVersion, tags) >>> versions = sorted(versions) >>> versions[-1].version (0, 23, 1)

TomAugspurger · 2018-06-25T12:59:01Z

Sorry I didn't mean to push those changes. Not sure whether it's worth auto-discovering.

jorisvandenbossche · 2018-06-25T20:48:10Z

Cool! Didn't have time to look into detail yet (will do that tomorrow), but some very quick feedback:

The docs are not yet building on travis: ModuleNotFoundError: No module named 'announce'
I get "/home/joris/scipy/pandas/doc/source/whatsnew/v0.20.3.txt: WARNING: document not readable. Ignored." for all whatsnew pages locally, but didn't further look into what is the cause (might be a problem on my side)
Big +1 on having the separate whatsnew files to separate html pages (already wanted to propose that for some time). However, the only problem is that this will break quite some links?
From a usability perspective of the "releases page", it would maybe be nice to include the highlights there, if this would be possible in some way.
Generating all the announce.build_string takes a non-negligible amount of time (when building the full docs probably not significant, but for a single page it might get annoying). Do we want to keep the script to generate it, but then actually include the content in the actual files (and use the script to generate it on release time) instead of generating it dynamically? (or otherwise skip it in certain cases, eg when building a single page that is not the releases pages)

jorisvandenbossche · 2018-06-25T20:50:46Z

Looks really good. There is just one thing that I'd consider changing. I don't think it's a good practice to import functions from scripts/

+ 1. We can maybe also put things in or alongside doc/make.py ?

TomAugspurger · 2018-06-25T20:57:01Z

alongside doc/make.py

Sure.

this will break quite some links?

Which ones? Anything using the "canonical" format like /version/x.y.z/ should be fine, since we aren't changing those.

it would maybe be nice to include the highlights there, if this would be possible in some way.

Agreed. I think highlights.rst will be a stub or something that gets included in several places

Do we want to keep the script to generate it, but then actually include the content in the actual files (and use the script to generate it on release time) instead of generating it dynamically?

I would slightly prefer to generate it dynamically. My goal is to remove the "final doc update" commit that's currently part of the release process. In theory, it should be possible to make this a Jinja2 macro that is called inside the actual whatsnew, rather than ahead of time.

TomAugspurger · 2018-06-25T20:58:18Z

I think it used to be to avoid warnings that they weren't included in a toctree? Maybe we can just change them.

…

On Mon, Jun 25, 2018 at 3:51 PM, Joris Van den Bossche < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/source/conf.py <#21599 (comment)>: > @@ -120,7 +122,10 @@ templates_path = ['../_templates'] # The suffix of source filenames. -source_suffix = '.rst' +source_suffix = [ + '.rst', + '.txt', Is there actually a reason they are not *.rst ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21599 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIpGSK_j6L7FGlRHyK7AuMuGtSKBZks5uAU1pgaJpZM4U0XNK> .

jorisvandenbossche · 2018-06-26T08:21:56Z

this will break quite some links?

Which ones? Anything using the "canonical" format like /version/x.y.z/ should be fine, since we aren't changing those.

Because it are now all separate pages, the url changes. For example, the first link in the highlights section of 0.23.0 points to http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#whatsnew-0230-enhancements-round-trippable-json. However, with this change the link will end in .../whatsnew/v0.23.0.html#whatsnew-0230-enhancements-round-trippable-json

jorisvandenbossche · 2018-06-26T08:29:50Z

scripts/announce.py

-    print(heading)
-    print(u"=" * len(heading))
-    print(author_msg % len(authors))
+    uline = '=' * len(heading)


this header does not always match the header levels in the whatsnew file

jorisvandenbossche · 2018-06-26T08:31:02Z

doc/source/conf.py

+    'v0.21.0': announce.build_string('v0.10.0..v0.21.0'),
+    'v0.21.1': announce.build_string('v0.10.0..v0.21.1'),
+    'v0.22.0': announce.build_string('v0.10.0..v0.22.0'),
+    'v0.22.0': announce.build_string('v0.22.0..v0.23.0'),


I suppose you know you still have some typos here (a lot of "v0.10.0" above, and this line is duplicated)

TomAugspurger · 2018-06-26T11:22:00Z

Yeah, I'm removing all this. Didn't mean to push it. I tried to write a new sphinx directive, so we can just do `.. contributors:: v0.23.1..v0.23.2`, but didn't get the rendering of the inserted text to work yet.

…

On Tue, Jun 26, 2018 at 3:31 AM, Joris Van den Bossche < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In scripts/announce.py <#21599 (comment)>: > authors = get_authors(revision_range) - heading = u"Contributors" - print() - print(heading) - print(u"=" * len(heading)) - print(author_msg % len(authors)) + uline = '=' * len(heading) this header does not always match the header levels in the whatsnew file ------------------------------ In doc/source/conf.py <#21599 (comment)>: > + 'v0.16.2': announce.build_string('v0.16.1..v0.16.2'), + 'v0.17.0': announce.build_string('v0.16.2..v0.17.0'), + 'v0.17.1': announce.build_string('v0.17.0..v0.17.1'), + 'v0.18.0': announce.build_string('v0.10.0..v0.18.0'), + 'v0.18.1': announce.build_string('v0.10.0..v0.18.1'), + 'v0.19.0': announce.build_string('v0.10.0..v0.19.0'), + 'v0.19.1': announce.build_string('v0.10.0..v0.19.1'), + 'v0.19.2': announce.build_string('v0.10.0..v0.19.2'), + 'v0.20.0': announce.build_string('v0.10.0..v0.20.0'), + 'v0.20.1': announce.build_string('v0.10.0..v0.20.1'), + 'v0.20.2': announce.build_string('v0.10.0..v0.20.2'), + 'v0.20.3': announce.build_string('v0.10.0..v0.20.3'), + 'v0.21.0': announce.build_string('v0.10.0..v0.21.0'), + 'v0.21.1': announce.build_string('v0.10.0..v0.21.1'), + 'v0.22.0': announce.build_string('v0.10.0..v0.22.0'), + 'v0.22.0': announce.build_string('v0.22.0..v0.23.0'), I suppose you know you still have some typos here (a lot of "v0.10.0" above, and this line is duplicated) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21599 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIkE93cGThlHgr7y1seHnce7EFJKDks5uAfFPgaJpZM4U0XNK> .

TomAugspurger · 2018-06-26T12:02:15Z

Ok, cleaned up my mess from yesterday. Replaced with a custom directive so we write

.. contributors:: v0.23.0..v0.23.1

rather than building them up ahead of time.

I haven't updated all the old files yet.

TomAugspurger · 2018-06-26T12:03:42Z

Will think about the links as well.

Writing the directive took a long time (I didn't realize I had to build the list of elements myself. I was hoping I could just pass it a string and have sphinx parse it), so I'm not sure I'll have time to finish this for 0.23.2.

jorisvandenbossche · 2018-06-26T12:36:19Z

so I'm not sure I'll have time to finish this for 0.23.2.

no problem, we can still go the normal way for that

TomAugspurger · 2018-11-13T16:55:39Z

Updated the headers.

…ation

…e-automation

h-vetinari

Looks like you inadvertently edited the wrong file

h-vetinari · 2018-11-13T17:16:43Z

doc/source/whatsnew/v0.20.2.rst

-v0.20.2 (June 4, 2017)
----------------------
+What's new in v0.20.2 (June 4, 2017)
+------------------------------------


Are you sure you wanted to do this in v.0.20.2 (which further increases the inconsistency) rather than v.0.24.0?

Alternatively, you could add "What's new in " to all versions (which would be even better than introducing it starting with 0.23.0)

TomAugspurger · 2018-11-13T17:34:05Z

I think I needed to change the 0.23+ headers to get the levels consistent. Not super interested in changing the old ones.

…ation

h-vetinari

Some tiny style comments, but nothing blocking. Also, you seem to have closed the PR by accident.

I think I needed to change the 0.23+ headers to get the levels consistent. Not super interested in changing the old ones.

Fair enough.

h-vetinari · 2018-11-13T17:39:06Z

doc/source/whatsnew/v0.23.0.rst

@@ -1,7 +1,9 @@
 .. _whatsnew_0230:

-v0.23.0 (May 15, 2018)
----------------------
+What's new in 0.23.0 (May 15, 2018)


Not a big deal, but "new" is capitalized for all the others. I'd go with lower-case for all.

h-vetinari · 2018-11-13T17:40:18Z

doc/source/releases.rst

+upgrade instructions, see :ref:`install`.
+
+0.24 release
+------------


I think it would look better (also looking at your render from the OP) to have

+ Version 0.24 - 0.24 release ------------

etc.

…ation

TomAugspurger · 2018-11-14T21:09:35Z

All green. Merging before we have more conflicts :)

I think this will require all outstanding PRs adding a release note to merge master. But contributors shouldn't have to manually fix any conflicts; git will handle things automatically.

* upstream/master: (25 commits) DOC: Delete trailing blank lines in docstrings. (pandas-dev#23651) DOC: Change release and whatsnew (pandas-dev#21599) DOC: Fix format of the See Also descriptions (pandas-dev#23654) DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. (pandas-dev#20374) ENH: Allow export of mixed columns to Stata strl (pandas-dev#23692) CLN: Remove unnecessary code (pandas-dev#23696) Pin flake8-rst version (pandas-dev#23699) Implement _most_ of the EA interface for DTA/TDA (pandas-dev#23643) CI: raise clone depth limit on CI BUG: Fix Series/DataFrame.rank(pct=True) with more than 2**24 rows (pandas-dev#23688) REF: Move Excel names parameter handling to CSV (pandas-dev#23690) DOC: Accessing files from a S3 bucket. (pandas-dev#23639) Fix errorbar visualization (pandas-dev#23674) DOC: Surface / doc mangle_dupe_cols in read_excel (pandas-dev#23678) DOC: Update is_sparse docstring (pandas-dev#19983) BUG: Fix read_excel w/parse_cols & empty dataset (pandas-dev#23661) Add to_flat_index method to MultiIndex (pandas-dev#22866) CLN: Move to_excel to generic.py (pandas-dev#23656) TST: IntervalTree.get_loc_interval should return platform int (pandas-dev#23660) CI: Allow to compile docs with ipython 7.11 pandas-dev#22990 (pandas-dev#23655) ...

…fixed * upstream/master: DOC: Delete trailing blank lines in docstrings. (pandas-dev#23651) DOC: Change release and whatsnew (pandas-dev#21599) DOC: Fix format of the See Also descriptions (pandas-dev#23654) DOC: update pandas.core.groupby.DataFrameGroupBy.resample docstring. (pandas-dev#20374) ENH: Allow export of mixed columns to Stata strl (pandas-dev#23692) CLN: Remove unnecessary code (pandas-dev#23696) Pin flake8-rst version (pandas-dev#23699) Implement _most_ of the EA interface for DTA/TDA (pandas-dev#23643) CI: raise clone depth limit on CI BUG: Fix Series/DataFrame.rank(pct=True) with more than 2**24 rows (pandas-dev#23688) REF: Move Excel names parameter handling to CSV (pandas-dev#23690) DOC: Accessing files from a S3 bucket. (pandas-dev#23639) Fix errorbar visualization (pandas-dev#23674) DOC: Surface / doc mangle_dupe_cols in read_excel (pandas-dev#23678) DOC: Update is_sparse docstring (pandas-dev#19983) BUG: Fix read_excel w/parse_cols & empty dataset (pandas-dev#23661) Add to_flat_index method to MultiIndex (pandas-dev#22866) CLN: Move to_excel to generic.py (pandas-dev#23656) TST: IntervalTree.get_loc_interval should return platform int (pandas-dev#23660)

jorisvandenbossche · 2018-11-15T10:26:13Z

@TomAugspurger the doc build is failing

Exception occurred:
  File "/home/travis/miniconda3/envs/pandas/lib/python3.6/site-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git shortlog -s v0.9.0..v0.10.0
  stderr: 'fatal: ambiguous argument 'v0.9.0..v0.10.0': unknown revision or path not in the working tree.

maybe because it has not a full clone?

TomAugspurger · 2018-11-15T11:57:35Z

Fixed (avoided) in #23714. I think you're right about the clone depth. Not a huge deal for the CI, though I'm a bit concerned things will be broken when we get to release time, and we'll need to scramble last minute to fix it.

…

On Thu, Nov 15, 2018 at 4:26 AM Joris Van den Bossche < ***@***.***> wrote: @TomAugspurger <https://github.com/TomAugspurger> the doc build is failing Exception occurred: File "/home/travis/miniconda3/envs/pandas/lib/python3.6/site-packages/git/cmd.py", line 825, in execute raise GitCommandError(command, status, stderr_value, stdout_value) git.exc.GitCommandError: Cmd('git') failed due to: exit code(128) cmdline: git shortlog -s v0.9.0..v0.10.0 stderr: 'fatal: ambiguous argument 'v0.9.0..v0.10.0': unknown revision or path not in the working tree. maybe because it has not a full clone? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21599 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIk_mCAgrqJKe4SdFzBTNPzFCilaqks5uvUFLgaJpZM4U0XNK> .

jorisvandenbossche · 2018-11-15T12:56:43Z

@TomAugspurger Thanks!

It would still be nice to have it run at the CI as well, as I would imagine that at some point we would like to rely on some CI service to build the docs and upload that version, instead of having the release manager it to do locally?

TomAugspurger · 2018-11-15T13:14:00Z

Yeah, I'm not sure what's best here... For now, we could hard code a `git fetch origin refs/tags/v0.23.4:refs/tags/v0.23.4` before doing the doc build. But then that's one more thing to remember to update manually, which was the entire point of this PR :)

…

On Thu, Nov 15, 2018 at 6:56 AM Joris Van den Bossche < ***@***.***> wrote: @TomAugspurger <https://github.com/TomAugspurger> Thanks! It would still be nice to have it run at the CI as well, as I would imagine that at some point we would like to rely on some CI service to build the docs and upload that version, instead of having the release manager it to do locally? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21599 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIty2L_XafvEKYdEqwamcpEuDmhJRks5uvWSRgaJpZM4U0XNK> .

* DOC: Change release and whatsnew Changes: * We will include the correct (latest on master or maintenance branch) whatsnew directly in the index.rst toctree * Contributors are included in the whatsnew for each version (automatically) * Removed release.rst * Added new releases.rst which has toctrees for each release Incidental changes * Updated style.ipynb. Writing the jinja template was confusing sphinx. We included it in the git source now. * Fixing some inconsitent header levels (will do more) * Refactored announce.py to support auto-generated contributors

TomAugspurger added the Docs label Jun 22, 2018

remove old file

721a41e

TomAugspurger commented Jun 22, 2018

View reviewed changes

TomAugspurger added 2 commits June 25, 2018 06:14

wip

8fb4fc7

DOC

d99c1da

datapythonista reviewed Jun 25, 2018

View reviewed changes

TomAugspurger added 2 commits June 25, 2018 17:04

move

583320c

directive

f6b1ee2

jorisvandenbossche reviewed Jun 26, 2018

View reviewed changes

TomAugspurger added 4 commits June 26, 2018 06:57

Added directive

33521c8

Updated announce

7cc8ca2

updated conf

fbc6bc6

Added ref

888306b

re-add rst2jinja

229d800

TomAugspurger added 2 commits June 27, 2018 15:26

whatsnew contributors

9cc76b0

headings

447a3f4

TomAugspurger added 2 commits November 13, 2018 10:58

Merge remote-tracking branch 'upstream/master' into doc-release-autom…

69be4b5

…ation

fixup! Merge remote-tracking branch 'upstream/master' into doc-releas…

3d9215d

…e-automation

h-vetinari reviewed Nov 13, 2018

View reviewed changes

header

61334d0

TomAugspurger closed this Nov 13, 2018

Merge remote-tracking branch 'upstream/master' into doc-release-autom…

1d8ad73

…ation

h-vetinari reviewed Nov 13, 2018

View reviewed changes

TomAugspurger reopened this Nov 13, 2018

TomAugspurger added 2 commits November 14, 2018 07:07

Merge remote-tracking branch 'upstream/master' into doc-release-autom…

1527aab

…ation

build inside repo

8a7e3e7

TomAugspurger mentioned this pull request Nov 14, 2018

DOC: Redirect old whatsnew links #23695

Open

TomAugspurger added 3 commits November 14, 2018 09:00

Merge remote-tracking branch 'upstream/master' into doc-release-autom…

34be519

…ation

release -> version

059e0bd

Merge remote-tracking branch 'upstream/master' into doc-release-autom…

bc5d49e

…ation

TomAugspurger merged commit e413c49 into pandas-dev:master Nov 14, 2018

TomAugspurger deleted the doc-release-automation branch November 14, 2018 21:09

datapythonista mentioned this pull request Dec 25, 2018

DOC: Removing old release.rst #24427

Merged

Harmon758 mentioned this pull request Feb 6, 2019

pandas changelog pyupio/changelogs#180

Closed

DOC: Change release and whatsnew #21599

DOC: Change release and whatsnew #21599

Conversation

TomAugspurger commented Jun 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 23, 2018 • edited Loading

Codecov Report

datapythonista commented Jun 23, 2018

pep8speaks commented Jun 25, 2018 • edited Loading

Comment last updated on June 26, 2018 at 12:00 Hours UTC

Choose a reason for hiding this comment

TomAugspurger commented Jun 25, 2018

jorisvandenbossche commented Jun 25, 2018 • edited Loading

jorisvandenbossche commented Jun 25, 2018

TomAugspurger commented Jun 25, 2018 • edited Loading

TomAugspurger commented Jun 25, 2018 via email

jorisvandenbossche commented Jun 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomAugspurger commented Jun 26, 2018 via email

TomAugspurger commented Jun 26, 2018

TomAugspurger commented Jun 26, 2018

jorisvandenbossche commented Jun 26, 2018

TomAugspurger commented Nov 13, 2018

h-vetinari left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomAugspurger commented Nov 13, 2018

h-vetinari left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomAugspurger commented Nov 14, 2018

jorisvandenbossche commented Nov 15, 2018

TomAugspurger commented Nov 15, 2018 via email

jorisvandenbossche commented Nov 15, 2018

TomAugspurger commented Nov 15, 2018 via email

TomAugspurger commented Jun 22, 2018 •

edited

Loading

codecov bot commented Jun 23, 2018 •

edited

Loading

pep8speaks commented Jun 25, 2018 •

edited

Loading

jorisvandenbossche commented Jun 25, 2018 •

edited

Loading

TomAugspurger commented Jun 25, 2018 •

edited

Loading