Tseries fixtures docstrings #21496
Tseries fixtures docstrings #21496
Conversation
…gara/pandas into tseries-fixtures-docstrings
Codecov Report
@@ Coverage Diff @@
## master #21496 +/- ##
==========================================
- Coverage 91.93% 91.93% -0.01%
==========================================
Files 159 160 +1
Lines 49733 49737 +4
==========================================
+ Hits 45721 45724 +3
- Misses 4012 4013 +1
Continue to review full report at Codecov.
|
pandas/tests/tseries/conftest.py
Outdated
| @@ -4,4 +4,7 @@ | |||
| @pytest.fixture(params=[None, 'UTC', 'Asia/Tokyo', 'US/Eastern', | |||
| 'dateutil/Asia/Tokyo', 'dateutil/US/Pacific']) | |||
| def tz(request): | |||
| """ | |||
There was a problem hiding this comment.
so happy to have you remove all of the tz fixtures (that are marked repeated), and use the top-level tz_naive_fixture (you can add 'dateutil/Asia/Tokyo') to that as well. I think that should be fine. you will need to change the references in each file (where the fixture is now) in order to make this work.
There was a problem hiding this comment.
Also will I need to change the reference to the tz fixture to the tz_naive_fixture right?
jreback
added
Testing
Cleanup and standarization of tz handling across tests.
|
Hello @ivergara! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on July 06, 2018 at 14:04 Hours UTC |
|
LGTM. Will merge this evening unless there's an objection. |
|
lgtm. merge away. |
|
thanks! |
|
Sure! Hope to keep contributing. |
git diff upstream/master -u -- "*.py" | flake8 --diff