Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "enable multivalues insert (#19664)" #21355

Conversation

jorisvandenbossche
Copy link
Member

This reverts commit 7c7bd56.

Reverts #19664
Closes #21103

@jorisvandenbossche
Copy link
Member Author

I didn't really know where to put this in the whatsnew file. Because as a revert it does not really fit in "bug fixes" IMO.
Any ideas? (I now added it in a section "regressions")

@jorisvandenbossche jorisvandenbossche added this to the 0.23.1 milestone Jun 7, 2018
@jorisvandenbossche jorisvandenbossche added the IO SQL to_sql, read_sql, read_sql_query label Jun 7, 2018
@TomAugspurger
Copy link
Contributor

Regressions seems fine, unless you read it as "We've introduced these new regressions!" :)

@jorisvandenbossche
Copy link
Member Author

I can make the title "Fixed regressions" :-)

@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #21355 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21355   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files         153      153           
  Lines       49564    49564           
=======================================
  Hits        45527    45527           
  Misses       4037     4037
Flag Coverage Δ
#multiple 90.25% <ø> (ø) ⬆️
#single 41.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649bfae...22a6dcf. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit c460710 into pandas-dev:master Jun 7, 2018
@jorisvandenbossche jorisvandenbossche deleted the revert-sql-multi-insert branch June 7, 2018 21:25
daminisatya pushed a commit to daminisatya/pandas that referenced this pull request Jun 8, 2018
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Jun 12, 2018
TomAugspurger pushed a commit that referenced this pull request Jun 12, 2018
This reverts commit 7c7bd56.

(cherry picked from commit c460710)
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants