DOC: whatsnew note for MultiIndex Sorting Fix #21316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be in the 0.24.0 whatsnew instead? The xref'd PR has a 0.24.0 milestone. Not opposed to this going in 0.23.1, just want to make sure this is aligned with the xref'd PR. |
|
Good question. Since it's a bug fix I am assuming v0.23.1 but can move if we want |
Codecov Report
@@ Coverage Diff @@
## master #21316 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 153 153
Lines 49549 49549
=======================================
Hits 45512 45512
Misses 4037 4037
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Jun 5, 2018
jorisvandenbossche
changed the title
|
OK, the fix seems rather small and it fixes an actual data corruption, so let's target it as 0.23.1 |
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Jun 12, 2018
(cherry picked from commit 15b39cd)
TomAugspurger
pushed a commit
that referenced
this pull request
Jun 12, 2018
(cherry picked from commit 15b39cd)
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #21043 (comment)