Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: removed unused "convert" parameter to _take #20934

Merged
merged 3 commits into from
May 3, 2018

Conversation

toobaz
Copy link
Member

@toobaz toobaz commented May 2, 2018

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Followup to #20841: the convert parameter to _take is irrelevant: the conversion of negative to positive indices is required only for Categoricals (and only until we normalize their take behavior with negative indices).

@toobaz toobaz added the Clean label May 2, 2018
@jreback jreback added this to the 0.23.0 milestone May 3, 2018
@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2ab3727). Click here to learn what that means.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #20934   +/-   ##
=========================================
  Coverage          ?   91.81%           
=========================================
  Files             ?      153           
  Lines             ?    49474           
  Branches          ?        0           
=========================================
  Hits              ?    45424           
  Misses            ?     4050           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.21% <84%> (?)
#single 41.85% <36%> (?)
Impacted Files Coverage Δ
pandas/core/groupby/groupby.py 92.58% <100%> (ø)
pandas/core/series.py 94.02% <100%> (ø)
pandas/core/indexing.py 93.55% <71.42%> (ø)
pandas/core/frame.py 97.13% <75%> (ø)
pandas/core/generic.py 95.93% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab3727...7aa63c2. Read the comment docs.

@jreback jreback merged commit 3340f27 into pandas-dev:master May 3, 2018
@jreback
Copy link
Contributor

jreback commented May 3, 2018

thanks!

FYI a more complete linter command is:

git diff master --name-only -- "*.py" | grep "pandas" | xargs flake8

(which catches unused things as well)

@toobaz toobaz deleted the take_remove_convert branch May 3, 2018 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants