Change _can_hold_na to a class attribute and document that it shouldn't be changed #20819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2018
TomAugspurger
added
the
ExtensionArray
TomAugspurger
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
lgtm. Will wait a bit if @jorisvandenbossche or @jreback have thoughts.
jreback
requested changes
Apr 25, 2018
| @@ -21,7 +21,7 @@ def test_ndim(self, data): | |||
| assert data.ndim == 1 | |||
|
|
|||
| def test_can_hold_na_valid(self, data): | |||
| assert data._can_hold_na in {True, False} | |||
| assert data._can_hold_na # Must be True | |||
There was a problem hiding this comment.
you can assert data._can_hold_na is True, otherwise this is not strictly checking that it is an actual boolean True
|
@TomAugspurger It seems that you made the change that @jreback asked for. Anything else for me to do? |
|
Nope, we're good. Thanks!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_can_hold_nagit diff upstream/master -u -- "*.py" | flake8 --diffExtensionArraysupport new for v0.23Replaces pull request #20815 (see discussion there for reasoning)