-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add concatenation-section to text.rst #20790
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20790 +/- ##
==========================================
- Coverage 91.85% 91.84% -0.01%
==========================================
Files 153 153
Lines 49308 49308
==========================================
- Hits 45290 45288 -2
- Misses 4018 4020 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. very minor comment
doc/source/text.rst
Outdated
u = pd.Series(['b', 'd', 'a', 'c'], index=[1, 3, 0, 2]) | ||
# without alignment | ||
s.str.cat(u) | ||
# manual alignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you say this is in a more user friendly way (don't like the word manual)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's another try. As an aside, the lack of alignment isn't user-friendly (which is exactly the point of #20347)
Build failure is not due to my commits (which do not touch the code base, just docs) |
thanks |
As requested by @jreback in #20347.