Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add concatenation-section to text.rst #20790

Merged
merged 6 commits into from
Apr 24, 2018

Conversation

h-vetinari
Copy link
Contributor

As requested by @jreback in #20347.

@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #20790 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20790      +/-   ##
==========================================
- Coverage   91.85%   91.84%   -0.01%     
==========================================
  Files         153      153              
  Lines       49308    49308              
==========================================
- Hits        45290    45288       -2     
- Misses       4018     4020       +2
Flag Coverage Δ
#multiple 90.23% <ø> (-0.01%) ⬇️
#single 41.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/strings.py 98.32% <ø> (ø) ⬆️
pandas/util/testing.py 84.59% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae7e90...4ae9196. Read the comment docs.

@jreback jreback added Docs Strings String extension data type and string data labels Apr 23, 2018
@jreback jreback added this to the 0.23.0 milestone Apr 23, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. very minor comment

u = pd.Series(['b', 'd', 'a', 'c'], index=[1, 3, 0, 2])
# without alignment
s.str.cat(u)
# manual alignment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you say this is in a more user friendly way (don't like the word manual)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's another try. As an aside, the lack of alignment isn't user-friendly (which is exactly the point of #20347)

@jreback
Copy link
Contributor

jreback commented Apr 23, 2018

@h-vetinari
Copy link
Contributor Author

Build failure is not due to my commits (which do not touch the code base, just docs)

@jreback jreback merged commit 5d0e815 into pandas-dev:master Apr 24, 2018
@jreback
Copy link
Contributor

jreback commented Apr 24, 2018

thanks

@h-vetinari h-vetinari deleted the str_cat_doc branch April 24, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants