Don't raise exceptions splitting a blank string #20067
Conversation
|
Hello @montanalow! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on March 17, 2018 at 19:42 Hours UTC |
|
this looks ok, though failing some other tests. you may need to adjust them. |
pandas/tests/test_strings.py
Outdated
| @@ -1943,6 +1943,13 @@ def test_split(self): | |||
| [u('f'), u('g'), u('h')]]) | |||
| tm.assert_series_equal(result, exp) | |||
|
|
|||
| # expand blank split | |||
There was a problem hiding this comment.
can you make a separate test
pandas/tests/test_strings.py
Outdated
| @@ -1943,6 +1943,13 @@ def test_split(self): | |||
| [u('f'), u('g'), u('h')]]) | |||
| tm.assert_series_equal(result, exp) | |||
|
|
|||
| # expand blank split | |||
| values = Series(['a b c', 'a b', '', ' ']) | |||
There was a problem hiding this comment.
can you also test on a single string, like the original issue. and add the issue number as a comment.
Codecov Report
@@ Coverage Diff @@
## master #20067 +/- ##
==========================================
+ Coverage 91.79% 91.8% +<.01%
==========================================
Files 152 152
Lines 49206 49206
==========================================
+ Hits 45170 45172 +2
+ Misses 4036 4034 -2
Continue to review full report at Codecov.
|
pandas/tests/test_strings.py
Outdated
| @@ -1992,6 +1992,19 @@ def test_rsplit(self): | |||
| exp = Series([['a_b', 'c'], ['c_d', 'e'], NA, ['f_g', 'h']]) | |||
| tm.assert_series_equal(result, exp) | |||
|
|
|||
| def test_split_blank_string(self): | |||
| # expand blank split GH 20067 | |||
| values = Series(['']) | |||
There was a problem hiding this comment.
can you add a name= to the Series so its clear where the name goes.
There was a problem hiding this comment.
Not sure I follow exactly what you mean. Are you suggesting adding name='test' as an arg to the constructor?
There was a problem hiding this comment.
yes add a name, the point is that this generates the column name for the frame.
pandas/tests/test_strings.py
Outdated
| @@ -1992,6 +1992,19 @@ def test_rsplit(self): | |||
| exp = Series([['a_b', 'c'], ['c_d', 'e'], NA, ['f_g', 'h']]) | |||
| tm.assert_series_equal(result, exp) | |||
|
|
|||
| def test_split_blank_string(self): | |||
| # expand blank split GH 20067 | |||
| values = Series(['']) | |||
There was a problem hiding this comment.
yes add a name, the point is that this generates the column name for the frame.
|
@jreback It looks like travis and appveyor canceled their builds, after I added names per request. Is there a retry mechanism for them? |
|
looks fine. can you rebase on master & add a whatsnew note? ping on green. |
montanalow
force-pushed
the
blank_strings
branch
2 times, most recently
from
dc2af53 to
6915c33
Compare
|
@jreback all green |
|
@montanalow can you add a release note to whatsnew/v0.23.0.txt under bug fixes? LGTM otherwise. |
montanalow
force-pushed
the
blank_strings
branch
from
6915c33 to
72dd252
Compare
|
@TomAugspurger note added |
[ci skip]
|
Thanks @montanalow ! |
…ame_describe * upstream/master: (158 commits) Add link to "Craft Minimal Bug Report" blogpost (pandas-dev#20431) BUG: fixed json_normalize for subrecords with NoneTypes (pandas-dev#20030) (pandas-dev#20399) BUG: ExtensionArray.fillna for scalar values (pandas-dev#20412) DOC" update the Pandas core window rolling count docstring" (pandas-dev#20264) DOC: update the pandas.DataFrame.plot.hist docstring (pandas-dev#20155) DOC: Only use ~ in class links to hide prefixes. (pandas-dev#20402) Bug: Allow np.timedelta64 objects to index TimedeltaIndex (pandas-dev#20408) DOC: add disallowing of Series construction of len-1 list with index to whatsnew (pandas-dev#20392) MAINT: Remove weird pd file DOC: update the Index.isin docstring (pandas-dev#20249) BUG: Handle all-NA blocks in concat (pandas-dev#20382) DOC: update the pandas.core.resample.Resampler.fillna docstring (pandas-dev#20379) BUG: Don't raise exceptions splitting a blank string (pandas-dev#20067) DOC: update the pandas.DataFrame.cummax docstring (pandas-dev#20336) DOC: update the pandas.core.window.x.mean docstring (pandas-dev#20265) DOC: update the api.types.is_number docstring (pandas-dev#20196) Fix linter (pandas-dev#20389) DOC: Improved the docstring of pandas.Series.dt.to_pytimedelta (pandas-dev#20142) DOC: update the pandas.Series.dt.is_month_end docstring (pandas-dev#20181) DOC: update the window.Rolling.min docstring (pandas-dev#20263) ...
whatsnew: bug fix on reshaping
git diff upstream/master -u -- "*.py" | flake8 --diff