Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scalar timestamp assignment (#19843) #19973

Merged
merged 7 commits into from
Aug 2, 2018
Merged

fix: scalar timestamp assignment (#19843) #19973

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a9b1b9
fix: scalar timestamp assignment (#19843)
DylanDmitri Mar 2, 2018
601cf54
moved tests
DylanDmitri Mar 2, 2018
33f8651
issue number in tests
DylanDmitri Mar 2, 2018
59069b9
added whatsnew
DylanDmitri Mar 3, 2018
edcb4e2
Merge branch 'master' into PR_TOOL_MERGE_PR_19973
jreback Aug 2, 2018
c48fbe9
update docs
jreback Aug 2, 2018
1b9649c
clean
jreback Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pandas/tests/frame/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@

from pandas.tests.frame.common import TestData

from pandas.core.dtypes.dtypes import DatetimeTZDtype


class TestDataFrameIndexing(TestData):

Expand Down Expand Up @@ -3042,6 +3044,22 @@ def test_transpose(self):
expected.index = ['A', 'B']
assert_frame_equal(result, expected)

def test_scalar_assignment(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference issue number for both tests.

df = pd.DataFrame(index=(0, 1, 2))

df['now'] = pd.Timestamp('20130101', tz='UTC')

assert isinstance(df.dtypes[0], DatetimeTZDtype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

construct the expected frame and use assert_frame_equal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this in class TestDataFrameIndexingDatetimeWithTZ(TestData)

name it test_setitem_scalar

parameterize it with both a tz and a tz-aware value.


def test_datetime_index_assignment(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a duplicate test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could put it as an additional test in the class as above if you'd like (parametrize as well)

df = pd.DataFrame(index=(0, 1, 2))

di = pd.DatetimeIndex(
[pd.Timestamp('20130101', tz='UTC')]).repeat(len(df))
df['now'] = di

assert isinstance(df.dtypes[0], DatetimeTZDtype)


class TestDataFrameIndexingUInt64(TestData):

Expand Down
23 changes: 0 additions & 23 deletions pandas/tests/scalar/timestamp/test_assignment_dtype.py
View file
Open in desktop

This file was deleted.