Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Debug flaky plotting test #19925

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Feb 27, 2018

Maybe closes #19924. I can't reproduce this locally so who knows.

A while back I went through and added plt.subplots() and explicit ax=ax to a bunch of the plotting tests. I apparently missed this one. It seemed to help, but they're flaky tests so who knows.

Also chanegd idx1.equals(idx2) to tm.assert_frame_equal so we get a better error message when it does fail.

@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Feb 27, 2018
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite Visualization plotting Unreliable Test Unit tests that occasionally fail labels Feb 27, 2018
@codecov
Copy link

codecov bot commented Feb 27, 2018

Codecov Report

Merging #19925 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19925      +/-   ##
==========================================
+ Coverage   91.66%   91.69%   +0.02%     
==========================================
  Files         150      150              
  Lines       48974    48974              
==========================================
+ Hits        44894    44906      +12     
+ Misses       4080     4068      -12
Flag Coverage Δ
#multiple 90.07% <ø> (+0.02%) ⬆️
#single 41.85% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c9d96...dd66dc5. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

It passed, not sure if it helped or not.

Merging later today if there are no objections.

@TomAugspurger TomAugspurger merged commit 7561eb8 into pandas-dev:master Feb 27, 2018
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
@TomAugspurger TomAugspurger deleted the datetimelike-test branch May 2, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Failing test on master
1 participant