Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add_offset_array for PeriodIndex #19826

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

jbrockmendel
Copy link
Member

This already works for DTI/TDI, this just rounds it out.

There will be some code de-duplication we can do if/when #19744 goes through.

@jreback jreback added the Period Period data type label Feb 22, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 22, 2018
@jreback
Copy link
Contributor

jreback commented Feb 22, 2018

lgtm. you want to de-dupliate code first?

@codecov
Copy link

codecov bot commented Feb 22, 2018

Codecov Report

Merging #19826 into master will increase coverage by 0.02%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19826      +/-   ##
==========================================
+ Coverage   91.58%   91.61%   +0.02%     
==========================================
  Files         150      150              
  Lines       48892    48905      +13     
==========================================
+ Hits        44780    44802      +22     
+ Misses       4112     4103       -9
Flag Coverage Δ
#multiple 89.98% <84.61%> (+0.02%) ⬆️
#single 41.78% <23.07%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/period.py 92.87% <84.61%> (-0.17%) ⬇️
pandas/core/indexes/datetimelike.py 96.84% <0%> (-0.22%) ⬇️
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1b168...a6d9714. Read the comment docs.

@jbrockmendel
Copy link
Member Author

lgtm. you want to de-dupliate code first?

If we're otherwise ready I'd rather merge and de-dup in the next pass. My turnaround is faster than the CI's.

@jreback jreback merged commit b585e3b into pandas-dev:master Feb 22, 2018
@jreback
Copy link
Contributor

jreback commented Feb 22, 2018

back to you :)

@jbrockmendel jbrockmendel deleted the pi_ops branch February 22, 2018 05:45
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants