-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep subclassing in apply #19823
Merged
Merged
Keep subclassing in apply #19823
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0df8689
Keep subclassing in apply
jaumebonet c3c1e5f
apply changes due to tests break
jaumebonet 0ef4bcf
FrameColumnApply.fix errors in wrap_result_for_axis
jaumebonet 7fd1178
Adding test and release note
jaumebonet 021e681
fix typo
jaumebonet c549397
update test_subclassed_apply and release note
jaumebonet 956143c
pep8 styling
jaumebonet dd929a8
Merge branch 'master' into apply-subclass
jaumebonet 06e11d2
test fix
jaumebonet e6bac37
fix test
jaumebonet e4f1c3e
fixed lint "line too long" error in travis ci
jaumebonet 8f7a0b4
fix test styling
jaumebonet 87f2c5c
fixed test typo
jaumebonet b22e090
fix docs
jaumebonet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to check the result of this using
tm.assert_frame_equal
, just use a simple example of an applied function, testing both returning a list, e.g.lambda x: [1, 2, 3]
and a sub-classed series