TST: move more series tests to test_arithmetic #19794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 21, 2018
| from pandas._libs.tslibs.period import IncompatibleFrequency | ||
|
|
||
| import pandas as pd | ||
| import pandas.util.testing as tm | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def tdser(): |
| with pytest.raises(TypeError): | ||
| vector - tdser | ||
|
|
||
| # ------------------------------------------------------------------ |
There was a problem hiding this comment.
these are nice comments / breaks, use liberally (as you are doing here, but elsewhere as well)
jreback
added
Testing
|
ping when pushed on comment. |
jreback
approved these changes
Feb 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #19794 +/- ##
==========================================
+ Coverage 91.61% 91.61% +<.01%
==========================================
Files 150 150
Lines 48887 48882 -5
==========================================
- Hits 44786 44782 -4
+ Misses 4101 4100 -1
Continue to review full report at Codecov.
|
|
Ping |
jorisvandenbossche
changed the title
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't overlap with other outstanding PRs.
Per usual, there is more that could be done, but we're doing this in pieces.
git diff upstream/master -u -- "*.py" | flake8 --diff