DOC: correct Series.searchsorted example #19784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ZhuBaohe! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on February 21, 2018 at 00:56 Hours UTC |
pandas/core/base.py
Outdated
| @@ -1154,32 +1154,27 @@ def factorize(self, sort=False, na_sentinel=-1): | |||
| dtype: int64 | |||
|
|
|||
| >>> x.searchsorted(4) | |||
| array([3]) | |||
| array([3], dtype=int64) | |||
There was a problem hiding this comment.
Is there a reason you are adding the 'dtype=int64' here? I don't see that in the output of my console.
There was a problem hiding this comment.
It appears in my console, but I already delete them in 6ffdac7
jorisvandenbossche
changed the title
Codecov Report
@@ Coverage Diff @@
## master #19784 +/- ##
==========================================
- Coverage 91.61% 91.6% -0.01%
==========================================
Files 150 150
Lines 48887 48887
==========================================
- Hits 44786 44784 -2
- Misses 4101 4103 +2
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Feb 21, 2018
|
@ZhuBaohe Thanks a lot! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two major changes:
categories must be ordered using series.searchsorted.
delete last two exsamples because of
ValueError: Value(s) to be inserted must be in categories.closes #xxxx
tests added / passed
passes
git diff upstream/master -u -- "*.py" | flake8 --diffwhatsnew entry