BUG: fix Series constructor for scalar and Categorical dtype #19717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Reshaping
gfyoung
approved these changes
Feb 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #19717 +/- ##
==========================================
- Coverage 91.61% 91.6% -0.01%
==========================================
Files 150 150
Lines 48882 48882
==========================================
- Hits 44782 44780 -2
- Misses 4100 4102 +2
Continue to review full report at Codecov.
|
|
Could you also add a test that hits the result = Series('a', index=[0, 1],
dtype=pd.api.types.CategoricalDtype(['a', 'b'], ordered=True)That way if the implementation changes in the future, we at least have that covered. |
jschendel
reviewed
Feb 16, 2018
pandas/core/dtypes/cast.py
Outdated
| @@ -1178,7 +1178,8 @@ def construct_1d_arraylike_from_scalar(value, length, dtype): | |||
| subarr = DatetimeIndex([value] * length, dtype=dtype) | |||
| elif is_categorical_dtype(dtype): | |||
| from pandas import Categorical | |||
| subarr = Categorical([value] * length) | |||
| subarr = Categorical([value] * length, dtype.categories, | |||
| ordered=dtype.ordered) | |||
There was a problem hiding this comment.
I think this could be done more concisely with Categorical([value] * length, dtype=dtype)
There was a problem hiding this comment.
Will do. I'll add a test for the Series constructor. @jschendel good point. I'll make that change as well.
cbertinato
force-pushed
the
issue-19565
branch
from
1276dad to
e33967f
Compare
Categories and ordering of the resulting Series were not the same as those of the passed Categorical dtype
cbertinato
force-pushed
the
issue-19565
branch
from
e33967f to
1357680
Compare
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Categories and ordering of the resulting Series were not the same as those of the passed Categorical dtype. Closes #19565
git diff upstream/master -u -- "*.py" | flake8 --diff