remove usages of _get_na_value #19692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Feb 14, 2018
pandas/core/indexes/base.py
Outdated
| @@ -4317,6 +4317,8 @@ def _ensure_index(index_like, copy=False): | |||
|
|
|||
|
|
|||
| def _get_na_value(dtype): | |||
| # TODO: remove; this may require a deprecation cycle because this is | |||
| # listed in indexes.api.__all_ | |||
There was a problem hiding this comment.
That's odd that that's the case! After all, the underscore means it should be private...
There was a problem hiding this comment.
this is not public and can be removed. the whole pandas.core.index bizness needs to be removed as well.
gfyoung
added
Internals
Codecov Report
@@ Coverage Diff @@
## master #19692 +/- ##
==========================================
+ Coverage 91.58% 91.6% +0.02%
==========================================
Files 150 150
Lines 48864 48862 -2
==========================================
+ Hits 44752 44762 +10
+ Misses 4112 4100 -12
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 15, 2018
pandas/core/indexes/base.py
Outdated
| @@ -4317,6 +4317,8 @@ def _ensure_index(index_like, copy=False): | |||
|
|
|||
|
|
|||
| def _get_na_value(dtype): | |||
| # TODO: remove; this may require a deprecation cycle because this is | |||
| # listed in indexes.api.__all_ | |||
There was a problem hiding this comment.
this is not public and can be removed. the whole pandas.core.index bizness needs to be removed as well.
4 tasks
jreback
approved these changes
Feb 16, 2018
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the function might also be incorrectly excluding period_dtype.